[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH 1/4] aio-posix: Introduce aio_set_io_event_n
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [RFC PATCH 1/4] aio-posix: Introduce aio_set_io_event_notifier |
Date: |
Wed, 27 May 2015 06:07:52 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 |
On 05/27/2015 01:19 AM, Fam Zheng wrote:
> This function will register the fd handler similar to
> aio_set_event_notifier, but the difference is the fd will only be polled
> in the outmost aio_poll.
s/outmost/outermost/
that will have a ripple effect throughout the patch series...
>
> This is useful in some cases like device ioeventfd, where the handler
> typically processes a guest request, therefore nested aio_poll shouldn't
> include this.
>
> Signed-off-by: Fam Zheng <address@hidden>
> ---
> aio-posix.c | 33 +++++++++++++++++++++++++++------
> include/block/aio.h | 23 ++++++++++++++++++++---
> 2 files changed, 47 insertions(+), 9 deletions(-)
>
> diff --git a/aio-posix.c b/aio-posix.c
> index 4abec38..05a0502 100644
> --- a/aio-posix.c
> +++ b/aio-posix.c
> @@ -24,6 +24,7 @@ struct AioHandler
> IOHandler *io_read;
> IOHandler *io_write;
> int deleted;
> + bool outmost;
...like here
But I'll probably let others do the technical review.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [RFC PATCH 0/4] aio: Don't poll ioeventfd in nested aio_poll(), Fam Zheng, 2015/05/27
- [Qemu-devel] [RFC PATCH 1/4] aio-posix: Introduce aio_set_io_event_notifier, Fam Zheng, 2015/05/27
- Re: [Qemu-devel] [RFC PATCH 1/4] aio-posix: Introduce aio_set_io_event_notifier,
Eric Blake <=
- [Qemu-devel] [RFC PATCH 2/4] aio-win32: Implement aio_set_io_event_notifier, Fam Zheng, 2015/05/27
- [Qemu-devel] [RFC PATCH 3/4] virtio-blk: Use aio_set_io_event_notifier in dataplane, Fam Zheng, 2015/05/27
- [Qemu-devel] [RFC PATCH 4/4] virtio-scsi-dataplane: User aio_set_io_event_notifier, Fam Zheng, 2015/05/27
- Re: [Qemu-devel] [RFC PATCH 0/4] aio: Don't poll ioeventfd in nested aio_poll(), Paolo Bonzini, 2015/05/27