[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v2 16/17] net/dp8393x: repair can_receive() method
From: |
Hervé Poussineau |
Subject: |
[Qemu-devel] [PATCH v2 16/17] net/dp8393x: repair can_receive() method |
Date: |
Wed, 27 May 2015 14:19:59 +0200 |
Datasheet clearly says that RXDIS flag prevents reception, but says
nothing about a required presence of RXEN flag.
While at it, fix the style of the following if statement.
Signed-off-by: Hervé Poussineau <address@hidden>
---
hw/net/dp8393x.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/hw/net/dp8393x.c b/hw/net/dp8393x.c
index 95a4d3d..b81036a 100644
--- a/hw/net/dp8393x.c
+++ b/hw/net/dp8393x.c
@@ -622,10 +622,12 @@ static int dp8393x_can_receive(NetClientState *nc)
{
dp8393xState *s = qemu_get_nic_opaque(nc);
- if (!(s->regs[SONIC_CR] & SONIC_CR_RXEN))
+ if (s->regs[SONIC_CR] & SONIC_CR_RXDIS) {
return 0;
- if (s->regs[SONIC_ISR] & SONIC_ISR_RBE)
+ }
+ if (s->regs[SONIC_ISR] & SONIC_ISR_RBE) {
return 0;
+ }
return 1;
}
--
2.1.4
- [Qemu-devel] [PATCH v2 02/17] dma/rc4030: create custom DMA address space, (continued)
- [Qemu-devel] [PATCH v2 02/17] dma/rc4030: create custom DMA address space, Hervé Poussineau, 2015/05/27
- [Qemu-devel] [PATCH v2 10/17] net/dp8393x: use dp8393x_ prefix for all functions, Hervé Poussineau, 2015/05/27
- [Qemu-devel] [PATCH v2 11/17] net/dp8393x: QOM'ify, Hervé Poussineau, 2015/05/27
- [Qemu-devel] [PATCH v2 17/17] [RFC] dma/rc4030: do multiple calls to address_space_rw when doing DMA transfers, Hervé Poussineau, 2015/05/27
- [Qemu-devel] [PATCH v2 07/17] dma/rc4030: convert to QOM, Hervé Poussineau, 2015/05/27
- [Qemu-devel] [PATCH v2 06/17] dma/rc4030: use trace events instead of custom logging, Hervé Poussineau, 2015/05/27
- [Qemu-devel] [PATCH v2 08/17] net/dp8393x: always calculate proper checksums, Hervé Poussineau, 2015/05/27
- [Qemu-devel] [PATCH v2 04/17] dma/rc4030: do not use old_mmio accesses, Hervé Poussineau, 2015/05/27
- [Qemu-devel] [PATCH v2 15/17] net/dp8393x: fix hardware reset, Hervé Poussineau, 2015/05/27
- [Qemu-devel] [PATCH v2 05/17] dma/rc4030: document register at offset 0x210, Hervé Poussineau, 2015/05/27
- [Qemu-devel] [PATCH v2 16/17] net/dp8393x: repair can_receive() method,
Hervé Poussineau <=
- [Qemu-devel] [PATCH v2 03/17] dma/rc4030: use AddressSpace and address_space_rw in users, Hervé Poussineau, 2015/05/27