[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 12/14] target-arm: Move TB flags down to fill ga
From: |
Edgar E. Iglesias |
Subject: |
Re: [Qemu-devel] [PATCH 12/14] target-arm: Move TB flags down to fill gap |
Date: |
Thu, 28 May 2015 15:53:09 +1000 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Tue, May 19, 2015 at 07:33:32PM +0100, Peter Maydell wrote:
> Deleting the now-unused ARM_TBFLAG_CPACR_FPEN left a gap in the
> bit usage; move the following ARM_TBFLAG_XSCALE_CPAR and
> ARM_TBFLAG_NS_SHIFT down 3 bits to fill the gap.
>
> Signed-off-by: Peter Maydell <address@hidden>
Reviewed-by: Edgar E. Iglesias <address@hidden>
> ---
> target-arm/cpu.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/target-arm/cpu.h b/target-arm/cpu.h
> index 647e0ba..dd7a90b 100644
> --- a/target-arm/cpu.h
> +++ b/target-arm/cpu.h
> @@ -1761,13 +1761,13 @@ static inline bool arm_singlestep_active(CPUARMState
> *env)
> /* We store the bottom two bits of the CPAR as TB flags and handle
> * checks on the other bits at runtime
> */
> -#define ARM_TBFLAG_XSCALE_CPAR_SHIFT 20
> +#define ARM_TBFLAG_XSCALE_CPAR_SHIFT 17
> #define ARM_TBFLAG_XSCALE_CPAR_MASK (3 << ARM_TBFLAG_XSCALE_CPAR_SHIFT)
> /* Indicates whether cp register reads and writes by guest code should access
> * the secure or nonsecure bank of banked registers; note that this is not
> * the same thing as the current security state of the processor!
> */
> -#define ARM_TBFLAG_NS_SHIFT 22
> +#define ARM_TBFLAG_NS_SHIFT 19
> #define ARM_TBFLAG_NS_MASK (1 << ARM_TBFLAG_NS_SHIFT)
>
> /* Bit usage when in AArch64 state: currently we have no A64 specific bits */
> --
> 1.9.1
>
- [Qemu-devel] [PATCH 08/14] target-arm: Allow cp access functions to indicate traps to EL2 or EL3, (continued)
- [Qemu-devel] [PATCH 08/14] target-arm: Allow cp access functions to indicate traps to EL2 or EL3, Peter Maydell, 2015/05/19
- [Qemu-devel] [PATCH 07/14] target-arm: Update interrupt handling to use target EL, Peter Maydell, 2015/05/19
- [Qemu-devel] [PATCH 01/14] target-arm: Add exception target el infrastructure, Peter Maydell, 2015/05/19
- [Qemu-devel] [PATCH 13/14] target-arm: Don't halt on WFI unless we don't have any work, Peter Maydell, 2015/05/19
- [Qemu-devel] [PATCH 12/14] target-arm: Move TB flags down to fill gap, Peter Maydell, 2015/05/19
- Re: [Qemu-devel] [PATCH 12/14] target-arm: Move TB flags down to fill gap,
Edgar E. Iglesias <=
- [Qemu-devel] [PATCH 04/14] target-arm: Move setting of exception info into tlb_fill, Peter Maydell, 2015/05/19
- [Qemu-devel] [PATCH 02/14] target-arm: Extend helpers to route exceptions, Peter Maydell, 2015/05/19
- [Qemu-devel] [PATCH 06/14] target-arm: Make raise_exception() take syndrome and target EL, Peter Maydell, 2015/05/19
- [Qemu-devel] [PATCH 03/14] target-arm: Set correct syndrome for faults on MSR DAIF*, imm, Peter Maydell, 2015/05/19