[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 0/5] Some fixes related to scsi-generic
From: |
Dimitris Aragiorgis |
Subject: |
Re: [Qemu-devel] [PATCH v4 0/5] Some fixes related to scsi-generic |
Date: |
Fri, 29 May 2015 08:15:34 +0300 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Hi,
* Dimitris Aragiorgis <address@hidden> [2015-05-20 12:57:34 +0300]:
> Hi all,
>
> These four patches make slight changes to the way QEMU handles SCSI
> generic devices to fix a number of small problems.
>
> I am sending them against the master branch, since I don't know if they
> can be considered bugfixes.
>
> Thanks,
> dimara
>
> v4 (rebased to current master):
> * Avoid errno clobbering with DPRINTF + strerror() (Eric's comment)
> * Use {} in #define macro even if it is not necessary (single commands)
>
Any news on this?
Thanks,
dimara
> v3 (rebased to current master):
> * Avoid bit-rot in DPRINTF (adopt Eric's suggestion)
> * Address Kevin's comments (DEBUF_FLOPPY, line > 80 chars, SG device)
> * Mention Kevin's comment wrt disk flush in the corresponding commit
>
> v2:
> * remove duplicate check for sg inside iscsi_co_flush()
> * remove DEBUG_BLOCK_PRINT in block/raw-posix.c
> * use DPRINTF for debugging in block/raw-posix.c
>
> PS: Paolo suggested to use a tracepoint inside hdev_is_sg() but I chose
> DPRINTF
> instead. It would make sense to add a tracepoint for bdrv_is_sg() (just like
> most bdrv_* commands) but this is too much for now since it just returns the
> bs->sg flag (and is not an actual driver function). If you insist I'll change
> it in v3.
>
> Dimitris Aragiorgis (5):
> block: Use bdrv_is_sg() everywhere
> Fix migration in case of scsi-generic
> raw-posix: DPRINTF instead of DEBUG_BLOCK_PRINT
> raw-posix: Use DPRINTF for DEBUG_FLOPPY
> raw-posix: Introduce hdev_is_sg()
>
> block.c | 6 ++--
> block/io.c | 3 +-
> block/iscsi.c | 4 ---
> block/raw-posix.c | 91
> +++++++++++++++++++++++++++++++----------------------
> 4 files changed, 58 insertions(+), 46 deletions(-)
>
> --
> 1.7.10.4
>
signature.asc
Description: Digital signature
- [Qemu-devel] [PATCH v4 0/5] Some fixes related to scsi-generic, Dimitris Aragiorgis, 2015/05/20
- [Qemu-devel] [PATCH v4 4/5] raw-posix: Use DPRINTF for DEBUG_FLOPPY, Dimitris Aragiorgis, 2015/05/20
- [Qemu-devel] [PATCH v4 1/5] block: Use bdrv_is_sg() everywhere, Dimitris Aragiorgis, 2015/05/20
- [Qemu-devel] [PATCH v4 2/5] Fix migration in case of scsi-generic, Dimitris Aragiorgis, 2015/05/20
- [Qemu-devel] [PATCH v4 3/5] raw-posix: DPRINTF instead of DEBUG_BLOCK_PRINT, Dimitris Aragiorgis, 2015/05/20
- [Qemu-devel] [PATCH v4 5/5] raw-posix: Introduce hdev_is_sg(), Dimitris Aragiorgis, 2015/05/20
- Re: [Qemu-devel] [PATCH v4 0/5] Some fixes related to scsi-generic,
Dimitris Aragiorgis <=