[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v3 13/21] monitor: Inline monitor_has_error() into i
From: |
Markus Armbruster |
Subject: |
[Qemu-devel] [PATCH v3 13/21] monitor: Inline monitor_has_error() into its only caller |
Date: |
Fri, 29 May 2015 11:56:52 +0200 |
Signed-off-by: Markus Armbruster <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Reviewed-by: Luiz Capitulino <address@hidden>
---
monitor.c | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/monitor.c b/monitor.c
index 56564d5..91f8a4e 100644
--- a/monitor.c
+++ b/monitor.c
@@ -377,11 +377,6 @@ static int GCC_FMT_ATTR(2, 3) monitor_fprintf(FILE *stream,
return 0;
}
-static inline int monitor_has_error(const Monitor *mon)
-{
- return mon->error != NULL;
-}
-
static void monitor_json_emitter(Monitor *mon, const QObject *data)
{
QString *json;
@@ -5031,7 +5026,7 @@ static void handle_qmp_command(JSONMessageParser *parser,
QList *tokens)
if (cmd->mhandler.cmd_new(mon, args, &data)) {
/* Command failed... */
- if (!monitor_has_error(mon)) {
+ if (!mon->error) {
/* ... without setting an error, so make one up */
qerror_report(QERR_UNDEFINED_ERROR);
}
--
1.9.3
- [Qemu-devel] [PATCH v3 00/21] monitor: Wean core off QError, and other cleanups, Markus Armbruster, 2015/05/29
- [Qemu-devel] [PATCH v3 02/21] monitor: Clean up after previous commit, Markus Armbruster, 2015/05/29
- [Qemu-devel] [PATCH v3 03/21] monitor: Improve and document client_migrate_info protocol error, Markus Armbruster, 2015/05/29
- [Qemu-devel] [PATCH v3 05/21] monitor: Use traditional command interface for HMP drive_del, Markus Armbruster, 2015/05/29
- [Qemu-devel] [PATCH v3 13/21] monitor: Inline monitor_has_error() into its only caller,
Markus Armbruster <=
- [Qemu-devel] [PATCH v3 10/21] monitor: Propagate errors through qmp_check_input_obj(), Markus Armbruster, 2015/05/29
- [Qemu-devel] [PATCH v3 08/21] monitor: Drop unused "new" HMP command interface, Markus Armbruster, 2015/05/29
- [Qemu-devel] [PATCH v3 12/21] monitor: Wean monitor_protocol_emitter() off mon->error, Markus Armbruster, 2015/05/29
- [Qemu-devel] [PATCH v3 06/21] monitor: Use traditional command interface for HMP device_add, Markus Armbruster, 2015/05/29
- [Qemu-devel] [PATCH v3 11/21] monitor: Propagate errors through invalid_qmp_mode(), Markus Armbruster, 2015/05/29
- Re: [Qemu-devel] [PATCH v3 11/21] monitor: Propagate errors through invalid_qmp_mode(), Eric Blake, 2015/05/29
- [Qemu-devel] [PATCH v3 14/21] monitor: Limit QError use to command handlers, Markus Armbruster, 2015/05/29