[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v8 06/54] Rename mis->file to from_src_file
From: |
Amit Shah |
Subject: |
Re: [Qemu-devel] [PATCH v8 06/54] Rename mis->file to from_src_file |
Date: |
Tue, 29 Sep 2015 16:11:47 +0530 |
On (Tue) 29 Sep 2015 [09:37:30], Dr. David Alan Gilbert (git) wrote:
> From: "Dr. David Alan Gilbert" <address@hidden>
>
> 'file' becomes confusing when you have flows in each direction;
> rename to make it clear.
> This leaves just the main forward direction ms->file, which is used
> in a lot of places and is probably not worth renaming given the churn.
>
> Signed-off-by: Dr. David Alan Gilbert <address@hidden>
Reviewed-by: Amit Shah <address@hidden>
I guess we could drop the '_file' in from_src_file too w/o loss of
info.
Also, if you have to respin, description has a typo: ms->file instead
of mis->file.
Amit
- [Qemu-devel] [PATCH v8 00/54] Postcopy implementation, Dr. David Alan Gilbert (git), 2015/10/01
- [Qemu-devel] [PATCH v8 02/54] Provide runtime Target page information, Dr. David Alan Gilbert (git), 2015/10/01
- [Qemu-devel] [PATCH v8 01/54] Add postcopy documentation, Dr. David Alan Gilbert (git), 2015/10/01
- [Qemu-devel] [PATCH v8 04/54] Move configuration section writing, Dr. David Alan Gilbert (git), 2015/10/01
- [Qemu-devel] [PATCH v8 03/54] Init page sizes in qtest, Dr. David Alan Gilbert (git), 2015/10/01
- [Qemu-devel] [PATCH v8 06/54] Rename mis->file to from_src_file, Dr. David Alan Gilbert (git), 2015/10/01
- Re: [Qemu-devel] [PATCH v8 06/54] Rename mis->file to from_src_file,
Amit Shah <=
- [Qemu-devel] [PATCH v8 05/54] qemu_ram_block_from_host, Dr. David Alan Gilbert (git), 2015/10/01
- [Qemu-devel] [PATCH v8 07/54] Add qemu_get_buffer_in_place to avoid copies some of the time, Dr. David Alan Gilbert (git), 2015/10/01
- [Qemu-devel] [PATCH v8 08/54] Add wrapper for setting blocking status on a QEMUFile, Dr. David Alan Gilbert (git), 2015/10/01
- [Qemu-devel] [PATCH v8 09/54] Add QEMU_MADV_NOHUGEPAGE, Dr. David Alan Gilbert (git), 2015/10/01
- [Qemu-devel] [PATCH v8 10/54] migration/ram.c: Use RAMBlock rather than MemoryRegion, Dr. David Alan Gilbert (git), 2015/10/01
- [Qemu-devel] [PATCH v8 11/54] ram_debug_dump_bitmap: Dump a migration bitmap as text, Dr. David Alan Gilbert (git), 2015/10/01
- [Qemu-devel] [PATCH v8 12/54] migrate_init: Call from savevm, Dr. David Alan Gilbert (git), 2015/10/01
- [Qemu-devel] [PATCH v8 13/54] Move dirty page search state into separate structure, Dr. David Alan Gilbert (git), 2015/10/01