Re: [Qemu-devel] [PATCH] Add mp-affinity property for ARM CPU class

[Peter Crosthwaite]

On Tue, Oct 13, 2015 at 10:54 AM, Peter Maydell
<address@hidden> wrote:
> On 9 October 2015 at 10:52, Pavel Fedin <address@hidden> wrote:
>> This allows to override default affinity IDs on a per-machine basis, and
>> possibility to retrieve IDs will be used by vGICv3 live migration code.
>>
>> Signed-off-by: Pavel Fedin <address@hidden>
>> ---
>> Since this popped up several times on the mailing list, i decided to publish 
>> this early.
>> ---
>>  target-arm/cpu.c | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/target-arm/cpu.c b/target-arm/cpu.c
>> index b48da33..3ebcebe 100644
>> --- a/target-arm/cpu.c
>> +++ b/target-arm/cpu.c
>> @@ -1379,6 +1379,7 @@ static Property arm_cpu_properties[] = {
>>      DEFINE_PROP_BOOL("start-powered-off", ARMCPU, start_powered_off, false),
>>      DEFINE_PROP_UINT32("psci-conduit", ARMCPU, psci_conduit, 0),
>>      DEFINE_PROP_UINT32("midr", ARMCPU, midr, 0),
>> +    DEFINE_PROP_UINT64("mp-affinity", ARMCPU, mp_affinity, 0),

Can we have separate props for each affinity level? Are you assuming
MPIDR format for this?

Regards,
Peter

>>      DEFINE_PROP_END_OF_LIST()
>>  };
>
> Nothing wrong with this patch, but I'd rather add it as part of
> the series which actually uses it. (I see you have it in one of
> your GICv3 patchsets.)
>
> thanks
> -- PMM
>