[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] PING: [PATCH v4 0/7] qom: more efficient object property ha
From: |
Pavel Fedin |
Subject: |
[Qemu-devel] PING: [PATCH v4 0/7] qom: more efficient object property handling |
Date: |
Tue, 20 Oct 2015 14:38:29 +0300 |
Hello! Is there any progress on this?
6/7 significantly improves startup performance, i'd like to have it accepted.
Kind regards,
Pavel Fedin
Expert Engineer
Samsung Electronics Research center Russia
> -----Original Message-----
> From: address@hidden [mailto:qemu-devel-
> address@hidden On Behalf Of Pavel Fedin
> Sent: Wednesday, October 14, 2015 9:58 AM
> To: 'Daniel P. Berrange'; address@hidden
> Cc: 'Paolo Bonzini'; 'Markus Armbruster'; 'Andreas Färber'
> Subject: Re: [Qemu-devel] [PATCH v4 0/7] qom: more efficient object property
> handling
>
> Hello!
>
> > This series introduces a concept of object property iterators
> > to QOM so callers are insulated from the specific data structures
> > used for storing properties against objects/classes. It then
> > converts Object to use a GHashTable for storing properties.
> > Finally it introduces ObjectClass properties.
>
> Tested-by: Pavel Fedin <address@hidden>
>
> > Probably the only controversial thing is the item Pavel points
> > out about object_child_foreach iterators now being forbidden
> > from modifying the object composition tree.
>
> As i already wrote, current code does not modify the tree. If necessary, it
> is possible to
> work around (e. g. make a decision about modification, stop iteration, then
> do the
> modification). I think this would pop up anyway if we change list to anything
> else. IMHO it's
> better just to acknowledge that we should not modify our tree inside iterator.
>
> Kind regards,
> Pavel Fedin
> Expert Engineer
> Samsung Electronics Research center Russia
>
- [Qemu-devel] PING: [PATCH v4 0/7] qom: more efficient object property handling,
Pavel Fedin <=