Re: [Qemu-devel] [PATCH v2 0/9] block: Fixes for bdrv_drain

[Kevin Wolf]

Am 29.10.2015 um 03:14 hat Fam Zheng geschrieben:
> v2: Add Kevin's reviewed-by in patches 1, 2, 5-7, 9.
>     Address Kevin's reviewing comments which are:
>     - Explicit "ret = 0" before out label in patch 3.
>     - Add missing qemu_aio_unref() in patch 4.
>     - Recurse into all children in bdrv_drain in patch 8.
> 
> Previously bdrv_drain and bdrv_drain_all don't handle ioctl, flush and discard
> requests (which are fundamentally the same as read and write requests that
> change disk state).  Forgetting such requests leaves us in risk of violating
> the invariant that bdrv_drain() callers rely on - all asynchronous requests
> must have completed after bdrv_drain returns.
> 
> Enrich the tracked request types, and add tracked_request_begin/end pairs to
> all three code paths. As a prerequisite, ioctl code is moved into coroutine
> too.
> 
> The last two patches take care of QED's "need check" timer, so that after
> bdrv_drain returns, the driver is in a consistent state.

Reviewed-by: Kevin Wolf <address@hidden>