[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/3] usb-mtp: Add support for inotify based file
From: |
Gerd Hoffmann |
Subject: |
Re: [Qemu-devel] [PATCH 2/3] usb-mtp: Add support for inotify based file monitoring |
Date: |
Thu, 05 Nov 2015 09:37:47 +0100 |
> +#include <sys/inotify.h>
What happens on non-linux systems?
I guess we need some #ifdefs to not break the build there, or enable mtp
only for CONFIG_LINUX=y instead of CONFIG_POSIX=y.
> +enum inotify_event_type {
> + CREATE = 1,
> + DELETE = 2,
> + MODIFY = 3,
> +};
Patch #3 removes this, I'd suggest to extent "enum mtp_code" with the
event codes here so we don't need this temporary thing.
cheers,
Gerd
- [Qemu-devel] [PATCH 0/3] usb-mtp events support, Bandan Das, 2015/11/03
- [Qemu-devel] [PATCH 1/3] usb-mtp: use a list for keeping track of children, Bandan Das, 2015/11/03
- [Qemu-devel] [PATCH 2/3] usb-mtp: Add support for inotify based file monitoring, Bandan Das, 2015/11/03
- Re: [Qemu-devel] [PATCH 2/3] usb-mtp: Add support for inotify based file monitoring,
Gerd Hoffmann <=
- Re: [Qemu-devel] [PATCH 2/3] usb-mtp: Add support for inotify based file monitoring, Gerd Hoffmann, 2015/11/05
- Re: [Qemu-devel] [PATCH 2/3] usb-mtp: Add support for inotify based file monitoring, Bandan Das, 2015/11/09
- Re: [Qemu-devel] [PATCH 2/3] usb-mtp: Add support for inotify based file monitoring, Bandan Das, 2015/11/09
- Re: [Qemu-devel] [PATCH 2/3] usb-mtp: Add support for inotify based file monitoring, Gerd Hoffmann, 2015/11/12
- Re: [Qemu-devel] [PATCH 2/3] usb-mtp: Add support for inotify based file monitoring, Bandan Das, 2015/11/12
- Re: [Qemu-devel] [PATCH 2/3] usb-mtp: Add support for inotify based file monitoring, Gerd Hoffmann, 2015/11/13
Re: [Qemu-devel] [PATCH 2/3] usb-mtp: Add support for inotify based file monitoring, Gerd Hoffmann, 2015/11/05
[Qemu-devel] [PATCH 3/3] usb-mtp: add support for basic mtp events, Bandan Das, 2015/11/03