Re: [Qemu-devel] [PATCH 14/16] hw/arm/virt: Wire up memory region to CPUs explicitly

[Edgar E. Iglesias]

On Thu, Nov 05, 2015 at 06:15:56PM +0000, Peter Maydell wrote:
> Wire up the system memory region to the CPUs explicitly
> by setting the QOM property. This doesn't change anything
> over letting it default, but will be needed for adding
> a secure memory region later.
> 
> Signed-off-by: Peter Maydell <address@hidden>

I'm not sure I understand this, if not set, wouldn't "memory"
just default to sysmem anyway regardless of if we set
"secure-memory" or not? I'm probably missing something
in the init/setup sequence...

Anyway, I don't mind explicitely setting "memory":
Reviewed-by: Edgar E. Iglesias <address@hidden>


> ---
>  hw/arm/virt.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/hw/arm/virt.c b/hw/arm/virt.c
> index 77d9267..3ab31e0 100644
> --- a/hw/arm/virt.c
> +++ b/hw/arm/virt.c
> @@ -1020,6 +1020,9 @@ static void machvirt_init(MachineState *machine)
>                                      "reset-cbar", &error_abort);
>          }
>  
> +        object_property_set_link(cpuobj, OBJECT(sysmem), "memory",
> +                                 &error_abort);
> +
>          object_property_set_bool(cpuobj, true, "realized", NULL);
>      }
>      g_strfreev(cpustr);
> -- 
> 1.9.1
>