Re: [Qemu-devel] [PATCH] configure: check for $cxx before use

[Peter Maydell]

On 12 November 2015 at 16:29, John Snow <address@hidden> wrote:
> I broke this when adding checks for clang++.
>
> Reported-by: Laurent Vivier <address@hidden>
> Signed-off-by: John Snow <address@hidden>
>
> ---
>  configure | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/configure b/configure
> index 46fd8bd..f75df4b 100755
> --- a/configure
> +++ b/configure
> @@ -4435,7 +4435,8 @@ fi
>  if test "$fortify_source" != "no"; then
>    if echo | $cc -dM -E - | grep __clang__ > /dev/null 2>&1 ; then
>      fortify_source="no";
> -  elif echo | $cxx -dM -E - | grep __clang__ > /dev/null 2>&1 ; then
> +  elif test -n "$cxx" &&
> +       echo | $cxx -dM -E - | grep __clang__ >/dev/null 2>&1 ; then
>      fortify_source="no";
>    else
>      fortify_source="yes"

Reviewed-by: Peter Maydell <address@hidden>

I'll apply it directly to master as a buildfix.

thanks
-- PMM