[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 10/14] migration: drop find_vmstate_bs check in hmp_d
From: |
Juan Quintela |
Subject: |
[Qemu-devel] [PULL 10/14] migration: drop find_vmstate_bs check in hmp_delvm |
Date: |
Thu, 19 Nov 2015 12:21:05 +0100 |
From: "Denis V. Lunev" <address@hidden>
There is no much sense to do the check and write warning.
Signed-off-by: Denis V. Lunev <address@hidden>
Reviewed-by: Stefan Hajnoczi <address@hidden>
Reviewed-by: Fam Zheng <address@hidden>
Reviewed-by: Juan Quintela <address@hidden>
Tested-by: Greg Kurz <address@hidden>
Signed-off-by: Juan Quintela <address@hidden>
---
migration/savevm.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/migration/savevm.c b/migration/savevm.c
index 4e6d578..63c07e1 100644
--- a/migration/savevm.c
+++ b/migration/savevm.c
@@ -2116,11 +2116,6 @@ void hmp_delvm(Monitor *mon, const QDict *qdict)
Error *err;
const char *name = qdict_get_str(qdict, "name");
- if (!find_vmstate_bs()) {
- monitor_printf(mon, "No block device supports snapshots\n");
- return;
- }
-
if (bdrv_all_delete_snapshot(name, &bs, &err) < 0) {
monitor_printf(mon,
"Error while deleting snapshot on device '%s': %s\n",
--
2.5.0
- [Qemu-devel] [PULL 00/14] Migration pull request, Juan Quintela, 2015/11/19
- [Qemu-devel] [PULL 02/14] migration: Dead assignment of current_time, Juan Quintela, 2015/11/19
- [Qemu-devel] [PULL 01/14] Set last_sent_block, Juan Quintela, 2015/11/19
- [Qemu-devel] [PULL 03/14] Unneeded NULL check, Juan Quintela, 2015/11/19
- [Qemu-devel] [PULL 04/14] snapshot: create helper to test that block drivers supports snapshots, Juan Quintela, 2015/11/19
- [Qemu-devel] [PULL 05/14] snapshot: return error code from bdrv_snapshot_delete_by_id_or_name, Juan Quintela, 2015/11/19
- [Qemu-devel] [PULL 07/14] snapshot: create bdrv_all_goto_snapshot helper, Juan Quintela, 2015/11/19
- [Qemu-devel] [PULL 08/14] migration: factor our snapshottability check in load_vmstate, Juan Quintela, 2015/11/19
- [Qemu-devel] [PULL 06/14] snapshot: create bdrv_all_delete_snapshot helper, Juan Quintela, 2015/11/19
- [Qemu-devel] [PULL 09/14] snapshot: create bdrv_all_find_snapshot helper, Juan Quintela, 2015/11/19
- [Qemu-devel] [PULL 10/14] migration: drop find_vmstate_bs check in hmp_delvm,
Juan Quintela <=
- [Qemu-devel] [PULL 11/14] snapshot: create bdrv_all_create_snapshot helper, Juan Quintela, 2015/11/19
- [Qemu-devel] [PULL 12/14] migration: reorder processing in hmp_savevm, Juan Quintela, 2015/11/19
- [Qemu-devel] [PULL 14/14] migration: normalize locking in migration/savevm.c, Juan Quintela, 2015/11/19
- [Qemu-devel] [PULL 13/14] migration: implement bdrv_all_find_vmstate_bs helper, Juan Quintela, 2015/11/19
- Re: [Qemu-devel] [PULL 00/14] Migration pull request, Peter Maydell, 2015/11/19