[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 01/18] slirp: goto bad in udp_input if sosendto fail
From: |
Samuel Thibault |
Subject: |
[Qemu-devel] [PATCH 01/18] slirp: goto bad in udp_input if sosendto fails |
Date: |
Fri, 11 Dec 2015 01:15:13 +0100 |
From: Guillaume Subiron <address@hidden>
Before this patch, if sosendto fails, udp_input is executed as if the
packet was sent, recording the packet for icmp errors, which does not
makes sense since the packet was not actually sent, errors would be
related to a previous packet.
This patch adds a goto bad to cut the execution of this function.
Signed-off-by: Guillaume Subiron <address@hidden>
Signed-off-by: Samuel Thibault <address@hidden>
---
slirp/debug.h | 2 +-
slirp/udp.c | 1 +
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/slirp/debug.h b/slirp/debug.h
index 6cfa61e..c60f967 100644
--- a/slirp/debug.h
+++ b/slirp/debug.h
@@ -5,7 +5,7 @@
* terms and conditions of the copyright.
*/
-//#define DEBUG 1
+#define DEBUG 1
#ifdef DEBUG
diff --git a/slirp/udp.c b/slirp/udp.c
index fee13b4..ce63414 100644
--- a/slirp/udp.c
+++ b/slirp/udp.c
@@ -218,6 +218,7 @@ udp_input(register struct mbuf *m, int iphlen)
*ip=save_ip;
DEBUG_MISC((dfd,"udp tx errno = %d-%s\n",errno,strerror(errno)));
icmp_error(m, ICMP_UNREACH,ICMP_UNREACH_NET, 0,strerror(errno));
+ goto bad;
}
m_free(so->so_m); /* used for ICMP if error on sorecvfrom */
--
2.6.2
- [Qemu-devel] [PATCHv5 00/18] slirp: Adding IPv6 support to Qemu -net user mode, Samuel Thibault, 2015/12/10
- [Qemu-devel] [PATCH 01/18] slirp: goto bad in udp_input if sosendto fails,
Samuel Thibault <=
- [Qemu-devel] [PATCH 09/18] qemu/timer.h : Adding function to second scale, Samuel Thibault, 2015/12/10
- [Qemu-devel] [PATCH 17/18] slirp: Adding IPv6 address for DNS relay, Samuel Thibault, 2015/12/10
- [Qemu-devel] [PATCH 05/18] slirp: Factorizing address translation, Samuel Thibault, 2015/12/10
- [Qemu-devel] [PATCH 12/18] slirp: Adding IPv6 UDP support, Samuel Thibault, 2015/12/10
- [Qemu-devel] [PATCH 07/18] slirp: Make udp_attach IPv6 compatible, Samuel Thibault, 2015/12/10
- [Qemu-devel] [PATCH 13/18] slirp: Factorizing tcpiphdr structure with an union, Samuel Thibault, 2015/12/10
- [Qemu-devel] [PATCH 14/18] slirp: Generalizing and neutralizing various TCP functions before adding IPv6 stuff, Samuel Thibault, 2015/12/10