Re: [Qemu-devel] [PATCH 01/74] tests: acpi: print ASL diff in verbose mode

[Michael S. Tsirkin]

On Thu, Dec 10, 2015 at 12:40:55AM +0100, Igor Mammedov wrote:
> Signed-off-by: Igor Mammedov <address@hidden>
> ---
>  tests/bios-tables-test.c | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/tests/bios-tables-test.c b/tests/bios-tables-test.c
> index 6d37332..50678b5 100644
> --- a/tests/bios-tables-test.c
> +++ b/tests/bios-tables-test.c
> @@ -580,6 +580,13 @@ static void test_acpi_asl(test_data *data)
>                          (gchar *)&signature,
>                          sdt->asl_file, sdt->aml_file,
>                          exp_sdt->asl_file, exp_sdt->aml_file);
> +                if (getenv("V")) {

How do you test? make check V=1?

> +                    int ret G_GNUC_UNUSED;
> +                    char *diff = g_strdup_printf("git diff --exit-code %s 
> %s",
> +                        exp_sdt->asl_file, sdt->asl_file);

This assumes running under git which is generally wrong e.g.
people build from tarballs.
git is also not a build dependency.


> +                    ret = system(diff) ;
> +                    g_free(diff);
> +                }
>            }
>          }
>          g_string_free(asl, true);
> -- 
> 1.8.3.1
>