|
| From: | Paolo Bonzini |
| Subject: | Re: [Qemu-devel] [PULL 14/55] ipmi: Add a local BMC simulation |
| Date: | Fri, 8 Jan 2016 10:05:44 +0100 |
| User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 |
On 22/12/2015 17:53, Michael S. Tsirkin wrote:
> +{
> + if ((netfn & 1) || (netfn > MAX_NETFNS) || (s->netfns[netfn / 2])) {
Off by one. The check should be >=, not >.
Paolo
> + return -1;
> + }
| [Prev in Thread] | Current Thread | [Next in Thread] |