[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v2 05/34] scripts/kvm/kvm_stat: Mark globals in func
From: |
Janosch Frank |
Subject: |
[Qemu-devel] [PATCH v2 05/34] scripts/kvm/kvm_stat: Mark globals in functions |
Date: |
Mon, 11 Jan 2016 16:17:35 +0100 |
Updating globals over the globals().update() method is not the
standard way of changing globals. Marking variables as global and
modifying them the standard way is better readable.
Signed-off-by: Janosch Frank <address@hidden>
---
scripts/kvm/kvm_stat | 41 ++++++++++++++++++++++-------------------
1 file changed, 22 insertions(+), 19 deletions(-)
diff --git a/scripts/kvm/kvm_stat b/scripts/kvm/kvm_stat
index 7a8617d..83450be 100755
--- a/scripts/kvm/kvm_stat
+++ b/scripts/kvm/kvm_stat
@@ -237,31 +237,34 @@ IOCTL_NUMBERS = {
}
def x86_init(flag):
- globals().update({
- 'SC_PERF_EVT_OPEN' : 298,
- 'EXIT_REASONS' : X86_EXIT_REASONS[flag],
- })
+ global SC_PERF_EVT_OPEN
+ global EXIT_REASONS
+
+ SC_PERF_EVT_OPEN = 298
+ EXIT_REASONS = X86_EXIT_REASONS[flag]
def s390_init():
- globals().update({
- 'SC_PERF_EVT_OPEN' : 331
- })
+ global SC_PERF_EVT_OPEN
+
+ SC_PERF_EVT_OPEN = 331
def ppc_init():
- globals().update({
- 'SC_PERF_EVT_OPEN' : 319,
- 'IOCTL_NUMBERS' : {
- 'SET_FILTER' : 0x80002406 | (ctypes.sizeof(ctypes.c_char_p) << 16),
- 'ENABLE' : 0x20002400,
- 'DISABLE' : 0x20002401,
- }
- })
+ global SC_PERF_EVT_OPEN
+ global IOCTL_NUMBERS
+
+ SC_PERF_EVT_OPEN = 319
+
+ IOCTL_NUMBERS['ENABLE'] = 0x20002400
+ IOCTL_NUMBERS['DISABLE'] = 0x20002401
+ IOCTL_NUMBERS['SET_FILTER'] = 0x80002406 | (ctypes.sizeof(ctypes.c_char_p)
+ << 16)
def aarch64_init():
- globals().update({
- 'SC_PERF_EVT_OPEN' : 241,
- 'EXIT_REASONS' : AARCH64_EXIT_REASONS,
- })
+ global SC_PERF_EVT_OPEN
+ global EXIT_REASONS
+
+ SC_PERF_EVT_OPEN = 241
+ EXIT_REASONS = AARCH64_EXIT_REASONS
def detect_platform():
if os.uname()[4].startswith('ppc'):
--
2.3.0
- [Qemu-devel] [PATCH v2 08/34] scripts/kvm/kvm_stat: Improve debugfs access checking, (continued)
- [Qemu-devel] [PATCH v2 08/34] scripts/kvm/kvm_stat: Improve debugfs access checking, Janosch Frank, 2016/01/11
- [Qemu-devel] [PATCH v2 29/34] scripts/kvm/kvm_stat: Cleanup and pre-init perf_event_attr, Janosch Frank, 2016/01/11
- [Qemu-devel] [PATCH v2 03/34] scripts/kvm/kvm_stat: Make constants uppercase, Janosch Frank, 2016/01/11
- [Qemu-devel] [PATCH v2 06/34] scripts/kvm/kvm_stat: Invert dictionaries, Janosch Frank, 2016/01/11
- [Qemu-devel] [PATCH v2 10/34] scripts/kvm/kvm_stat: Fix spaces around keyword assignments, Janosch Frank, 2016/01/11
- [Qemu-devel] [PATCH v2 22/34] scripts/kvm/kvm_stat: Cleanup of Stats class, Janosch Frank, 2016/01/11
- [Qemu-devel] [PATCH v2 30/34] scripts/kvm/kvm_stat: Read event values as u64, Janosch Frank, 2016/01/11
- [Qemu-devel] [PATCH v2 31/34] scripts/kvm/kvm_stat: Fix rlimit for unprivileged users, Janosch Frank, 2016/01/11
- [Qemu-devel] [PATCH v2 13/34] scripts/kvm/kvm_stat: Fixup syscall error reporting, Janosch Frank, 2016/01/11
- [Qemu-devel] [PATCH v2 05/34] scripts/kvm/kvm_stat: Mark globals in functions,
Janosch Frank <=
- [Qemu-devel] [PATCH v2 14/34] scripts/kvm/kvm_stat: Set sensible no. files rlimit, Janosch Frank, 2016/01/11
- [Qemu-devel] [PATCH v2 24/34] scripts/kvm/kvm_stat: Cleanup of Event class, Janosch Frank, 2016/01/11
- [Qemu-devel] [PATCH v2 20/34] scripts/kvm/kvm_stat: Cleanup cpu list retrieval, Janosch Frank, 2016/01/11
- [Qemu-devel] [PATCH v2 34/34] scripts/kvm/kvm_stat: Add optparse description, Janosch Frank, 2016/01/11
- [Qemu-devel] [PATCH v2 21/34] scripts/kvm/kvm_stat: Encapsulate filters variable, Janosch Frank, 2016/01/11
- [Qemu-devel] [PATCH v2 27/34] scripts/kvm/kvm_stat: Make tui function a class, Janosch Frank, 2016/01/11
- [Qemu-devel] [PATCH v2 28/34] scripts/kvm/kvm_stat: Fix output formatting, Janosch Frank, 2016/01/11
- [Qemu-devel] [PATCH v2 32/34] scripts/kvm/kvm_stat: Fixup filtering, Janosch Frank, 2016/01/11
- [Qemu-devel] [PATCH v2 26/34] scripts/kvm/kvm_stat: Remove unneeded X86_EXIT_REASONS, Janosch Frank, 2016/01/11
- [Qemu-devel] [PATCH v2 33/34] scripts/kvm/kvm_stat: Add interactive filtering, Janosch Frank, 2016/01/11