[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v8 15/15] iotests: Add "qemu-img map" test for V
From: |
Max Reitz |
Subject: |
Re: [Qemu-devel] [PATCH v8 15/15] iotests: Add "qemu-img map" test for VMDK extents |
Date: |
Mon, 25 Jan 2016 15:17:35 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 |
On 25.01.2016 15:11, Max Reitz wrote:
> On 25.01.2016 03:44, Fam Zheng wrote:
>> Signed-off-by: Fam Zheng <address@hidden>
>> ---
>> tests/qemu-iotests/059 | 10 ++++++++++
>> tests/qemu-iotests/059.out | 26 ++++++++++++++++++++++++++
>> 2 files changed, 36 insertions(+)
>>
>> diff --git a/tests/qemu-iotests/059 b/tests/qemu-iotests/059
>> index 0ded0c3..0332bbb 100755
>> --- a/tests/qemu-iotests/059
>> +++ b/tests/qemu-iotests/059
>> @@ -133,6 +133,16 @@ $QEMU_IO -c "write -P 0xa 900G 512" "$TEST_IMG" |
>> _filter_qemu_io
>> $QEMU_IO -c "read -v 900G 1024" "$TEST_IMG" | _filter_qemu_io
>>
>> echo
>> +echo "=== Testing qemu-img map on extents ==="
>> +for fmt in monolithicSparse twoGbMaxExtentSparse; do
>> + IMGOPTS="subformat=$fmt" _make_test_img 31G
>> + $QEMU_IO -c "write 65024 1k" "$TEST_IMG" | _filter_qemu_io
>> + $QEMU_IO -c "write 2147483136 1k" "$TEST_IMG" | _filter_qemu_io
>> + $QEMU_IO -c "write 5G 1k" "$TEST_IMG" | _filter_qemu_io
>> + $QEMU_IMG map "$TEST_IMG" | _filter_testdir
>> +done
>> +
>> +echo
>> echo "=== Testing afl image with a very large capacity ==="
>> _use_sample_img afl9.vmdk.bz2
>> _img_info
>> diff --git a/tests/qemu-iotests/059.out b/tests/qemu-iotests/059.out
>> index 9d506cb..5e041d7 100644
>> --- a/tests/qemu-iotests/059.out
>> +++ b/tests/qemu-iotests/059.out
>> @@ -2050,6 +2050,7 @@ wrote 512/512 bytes at offset 0
>> 512 bytes, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
>> wrote 512/512 bytes at offset 10240
>> 512 bytes, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
>> +qemu-img: Could not open
>> '/home/fam/build/last/tests/qemu-iotests/scratch/t.vmdk': VMDK version 3
>> must be read only
...and I just noticed that my home directory is called /home/maxx and
not /home/fam. :-)
> I'd rather have the test fail than include this apparently wrong line
> (according to
> http://lists.nongnu.org/archive/html/qemu-block/2016-01/msg00710.html)
> here, but I'll leave that up to you.
>
> Reviewed-by: Max Reitz <address@hidden>
So I'll have to revoke this R-b.
Max
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v8 09/15] vdi: Assign bs->file->bs to file in vdi_co_get_block_status, (continued)
- [Qemu-devel] [PATCH v8 09/15] vdi: Assign bs->file->bs to file in vdi_co_get_block_status, Fam Zheng, 2016/01/24
- [Qemu-devel] [PATCH v8 10/15] vpc: Assign bs->file->bs to file in vpc_co_get_block_status, Fam Zheng, 2016/01/24
- [Qemu-devel] [PATCH v8 11/15] vmdk: Return extent's file in bdrv_get_block_status, Fam Zheng, 2016/01/24
- [Qemu-devel] [PATCH v8 12/15] block: Use returned *file in bdrv_co_get_block_status, Fam Zheng, 2016/01/24
- [Qemu-devel] [PATCH v8 13/15] qemu-img: In "map", use the returned "file" from bdrv_get_block_status, Fam Zheng, 2016/01/24
- [Qemu-devel] [PATCH v8 14/15] qemu-img: Make MapEntry a QAPI struct, Fam Zheng, 2016/01/24
- [Qemu-devel] [PATCH v8 15/15] iotests: Add "qemu-img map" test for VMDK extents, Fam Zheng, 2016/01/24
- Re: [Qemu-devel] [PATCH v8 00/15] qemu-img map: Allow driver to return file of the allocated block, Kevin Wolf, 2016/01/25