[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 05/17] slirp: goto bad in udp_input if sosendto fails
From: |
Jason Wang |
Subject: |
[Qemu-devel] [PULL 05/17] slirp: goto bad in udp_input if sosendto fails |
Date: |
Tue, 2 Feb 2016 10:36:09 +0800 |
From: Guillaume Subiron <address@hidden>
Before this patch, if sosendto fails, udp_input is executed as if the
packet was sent, recording the packet for icmp errors, which does not
makes sense since the packet was not actually sent, errors would be
related to a previous packet.
This patch adds a goto bad to cut the execution of this function.
Signed-off-by: Guillaume Subiron <address@hidden>
Signed-off-by: Samuel Thibault <address@hidden>
Reviewed-by: Thomas Huth <address@hidden>
Signed-off-by: Jason Wang <address@hidden>
---
slirp/udp.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/slirp/udp.c b/slirp/udp.c
index fee13b4..ce63414 100644
--- a/slirp/udp.c
+++ b/slirp/udp.c
@@ -218,6 +218,7 @@ udp_input(register struct mbuf *m, int iphlen)
*ip=save_ip;
DEBUG_MISC((dfd,"udp tx errno = %d-%s\n",errno,strerror(errno)));
icmp_error(m, ICMP_UNREACH,ICMP_UNREACH_NET, 0,strerror(errno));
+ goto bad;
}
m_free(so->so_m); /* used for ICMP if error on sorecvfrom */
--
2.5.0
- [Qemu-devel] [PULL 00/17] Net patches, Jason Wang, 2016/02/01
- [Qemu-devel] [PULL 01/17] net/slirp: Tell the users when they are using deprecated options, Jason Wang, 2016/02/01
- [Qemu-devel] [PULL 02/17] qemu-doc: Do not promote deprecated -smb and -redir options, Jason Wang, 2016/02/01
- [Qemu-devel] [PULL 03/17] net: cadence_gem: check packet size in gem_recieve, Jason Wang, 2016/02/01
- [Qemu-devel] [PULL 04/17] cadence_gem: fix buffer overflow, Jason Wang, 2016/02/01
- [Qemu-devel] [PULL 05/17] slirp: goto bad in udp_input if sosendto fails,
Jason Wang <=
- [Qemu-devel] [PULL 06/17] slirp: Generalizing and neutralizing ARP code, Jason Wang, 2016/02/01
- [Qemu-devel] [PULL 07/17] slirp: Adding address family switch for produced frames, Jason Wang, 2016/02/01
- [Qemu-devel] [PULL 08/17] slirp: Make Socket structure IPv6 compatible, Jason Wang, 2016/02/01
- [Qemu-devel] [PULL 09/17] slirp: Factorizing address translation, Jason Wang, 2016/02/01
- [Qemu-devel] [PULL 10/17] slirp: Factorizing and cleaning solookup(), Jason Wang, 2016/02/01
- [Qemu-devel] [PULL 11/17] slirp: Add sockaddr_equal, make solookup family-agnostic, Jason Wang, 2016/02/01
- [Qemu-devel] [PULL 12/17] slirp: Make udp_attach IPv6 compatible, Jason Wang, 2016/02/01
- [Qemu-devel] [PULL 13/17] slirp: Adding family argument to tcp_fconnect(), Jason Wang, 2016/02/01
- [Qemu-devel] [PULL 14/17] e1000: eliminate infinite loops on out-of-bounds transfer start, Jason Wang, 2016/02/01
- [Qemu-devel] [PULL 15/17] net: netmap: use nm_open() to open netmap ports, Jason Wang, 2016/02/01