[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/4] usb: add attached property
|
From: |
Markus Armbruster |
|
Subject: |
Re: [Qemu-devel] [PATCH 2/4] usb: add attached property |
|
Date: |
Tue, 02 Feb 2016 16:37:00 +0100 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) |
Gerd Hoffmann <address@hidden> writes:
> Hi,
>
>> > USB devices in attached state are visible to the guest.
>>
>> If I read the code correctly:
>>
>> * ->attached is true between usb_device_attach() and usb_device_detach()
>>
>> * Attach and detach is automatic on realize and unrealize, but a device
>> can choose to suppress attach on realize, by unsetting ->auto_attach,
>> and manage attach/detach itself.
>>
>> * A detached device is wired up normally in QOM, but the USB core treats
>> it as not plugged into its USB port.
>>
>> Correct?
>
> Yes.
Preferrably with the commit message improved along the line of my
suggestions:
Reviewed-by: Markus Armbruster <address@hidden>