[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/2] block/nbd: Reject port parameter without ho
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 1/2] block/nbd: Reject port parameter without host |
Date: |
Wed, 3 Feb 2016 09:38:20 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 |
On 02/03/2016 09:33 AM, Max Reitz wrote:
> This is better than the generic block layer finding out later that the
> port parameter has not been used.
>
> Signed-off-by: Max Reitz <address@hidden>
> ---
> block/nbd.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/block/nbd.c b/block/nbd.c
> index 1a90bc7..063c403 100644
> --- a/block/nbd.c
> +++ b/block/nbd.c
> @@ -201,6 +201,10 @@ static SocketAddress *nbd_config(BDRVNBDState *s, QDict
> *options, char **export,
> }
> return NULL;
> }
> + if (qdict_haskey(options, "port") && !qdict_haskey(options, "host")) {
> + error_setg(errp, "port may not be used without host.");
No trailing '.'
With that fixed,
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature