[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 4/5] virtio-balloon: rewrite get_current_ram_siz
From: |
Cornelia Huck |
Subject: |
Re: [Qemu-devel] [PATCH 4/5] virtio-balloon: rewrite get_current_ram_size() |
Date: |
Thu, 4 Feb 2016 13:23:35 +0100 |
On Thu, 4 Feb 2016 14:37:22 +0300
Vladimir Sementsov-Ogievskiy <address@hidden> wrote:
> Use pc_dimm_built_list() instead of qmp_pc_dimm_device_list()
>
> Actually, Qapi is not related to this internal helper.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
>
> CC: Stefan Hajnoczi <address@hidden>
> CC: Xiao Guangrong <address@hidden>
> CC: "Michael S. Tsirkin" <address@hidden>
> CC: Igor Mammedov <address@hidden>
> CC: Eric Blake <address@hidden>
> CC: Markus Armbruster <address@hidden>
> ---
> hw/virtio/virtio-balloon.c | 23 ++++++-----------------
> 1 file changed, 6 insertions(+), 17 deletions(-)
>
> diff --git a/hw/virtio/virtio-balloon.c b/hw/virtio/virtio-balloon.c
> index 6a4c4d2..b9c1964 100644
> --- a/hw/virtio/virtio-balloon.c
> +++ b/hw/virtio/virtio-balloon.c
> @@ -296,26 +296,15 @@ static void virtio_balloon_get_config(VirtIODevice
> *vdev, uint8_t *config_data)
>
> static ram_addr_t get_current_ram_size(void)
> {
> - MemoryDeviceInfoList *info_list = NULL;
> - MemoryDeviceInfoList **prev = &info_list;
> - MemoryDeviceInfoList *info;
> + GSList *list = NULL, *item;
> ram_addr_t size = ram_size;
>
> - qmp_pc_dimm_device_list(qdev_get_machine(), &prev);
> - for (info = info_list; info; info = info->next) {
> - MemoryDeviceInfo *value = info->value;
> -
> - if (value) {
> - switch (value->type) {
> - case MEMORY_DEVICE_INFO_KIND_DIMM:
> - size += value->u.dimm->size;
> - break;
> - default:
> - break;
> - }
> - }
> + pc_dimm_build_list(qdev_get_machine(), &list);
This will break the build for !CONFIG_MEM_HOTPLUG, as you didn't
provide a stubbed-out version of this function.
> + for (item = list; item; item = g_slist_next(item)) {
> + PCDIMMDevice *dimm = item->data;
> + size += object_property_get_int(OBJECT(dimm), PC_DIMM_SIZE_PROP,
> NULL);
> }
> - qapi_free_MemoryDeviceInfoList(info_list);
> + g_slist_free(list);
>
> return size;
> }
- [Qemu-devel] [PATCH v5 0/5] don't use NVDIMM for balooning, Vladimir Sementsov-Ogievskiy, 2016/02/04
- [Qemu-devel] [PATCH 1/5] move get_current_ram_size to virtio-balloon.c, Vladimir Sementsov-Ogievskiy, 2016/02/04
- [Qemu-devel] [PATCH 2/5] pc-dimm: rename pc_dimm_built_list(), Vladimir Sementsov-Ogievskiy, 2016/02/04
- [Qemu-devel] [PATCH 3/5] pc-dimm: add pc_dimm_build_list(), Vladimir Sementsov-Ogievskiy, 2016/02/04
- [Qemu-devel] [PATCH 5/5] balloon: Use only 'pc-dimm' type dimm for ballooning, Vladimir Sementsov-Ogievskiy, 2016/02/04
- [Qemu-devel] [PATCH 4/5] virtio-balloon: rewrite get_current_ram_size(), Vladimir Sementsov-Ogievskiy, 2016/02/04
- Re: [Qemu-devel] [PATCH 4/5] virtio-balloon: rewrite get_current_ram_size(),
Cornelia Huck <=
- Re: [Qemu-devel] [PATCH v5 0/5] don't use NVDIMM for balooning, Igor Mammedov, 2016/02/04