[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v5 07/10] qemu-img: allow specifying image as a
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-devel] [PATCH v5 07/10] qemu-img: allow specifying image as a set of options args |
Date: |
Thu, 4 Feb 2016 17:06:06 +0100 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Am 04.02.2016 um 16:47 hat Daniel P. Berrange geschrieben:
> On Thu, Feb 04, 2016 at 04:42:06PM +0100, Kevin Wolf wrote:
> > Am 02.02.2016 um 13:57 hat Daniel P. Berrange geschrieben:
> > > @@ -1956,7 +2034,13 @@ static int img_convert(int argc, char **argv)
> > > goto out;
> > > }
> > >
> > > - out_blk = img_open("target", out_filename, out_fmt, flags, true,
> > > quiet);
> > > + /* XXX we should allow --image-opts to trigger use of
> > > + * img_open() here, but then we have trouble with
> > > + * the bdrv_create() call which takes different params.
> > > + * Not critical right now, so fix can wait...
> > > + */
> > > + out_blk = img_open_file("target", out_filename,
> > > + out_fmt, flags, true, quiet);
> >
> > So is the plan to add another option (like --target-image-opts) when
> > this call is converted?
>
> Well I was hoping --image-opts would affect both source and target,
> but i guess if we ship it only affecting source, we can't extend
> it to also affect target without back compat issues, so that might
> force adding a --target-image-opts
Yes, that's exactly why I'm asking. We need to decide now whether this
would be an acceptable outcome or whether we shouldn't have --image-opts
in this command for now at all.
Kevin
- Re: [Qemu-devel] [PATCH v5 02/10] qemu-img: add support for --object command line arg, (continued)
Re: [Qemu-devel] [PATCH v5 07/10] qemu-img: allow specifying image as a set of options args, Eric Blake, 2016/02/04
[Qemu-devel] [PATCH v5 04/10] qemu-io: add support for --object command line arg, Daniel P. Berrange, 2016/02/02
[Qemu-devel] [PATCH v5 09/10] qemu-nbd: use no_argument/required_argument constants, Daniel P. Berrange, 2016/02/02
[Qemu-devel] [PATCH v5 08/10] qemu-nbd: don't overlap long option values with short options, Daniel P. Berrange, 2016/02/02
Re: [Qemu-devel] [PATCH v5 00/10] Make qemu-img/qemu-nbd/qemu-io CLI more flexible, Kevin Wolf, 2016/02/04