[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/2] ipmi_bmc_sim: Fix off by one in check.
From: |
Michael S. Tsirkin |
Subject: |
Re: [Qemu-devel] [PATCH 1/2] ipmi_bmc_sim: Fix off by one in check. |
Date: |
Mon, 8 Feb 2016 12:43:04 +0200 |
On Mon, Jan 11, 2016 at 07:32:31AM -0600, address@hidden wrote:
> From: Corey Minyard <address@hidden>
>
> Found by Paolo.
>
> Cc: Paolo Bonzini <address@hidden>
> Cc: Michael S. Tsirkin <address@hidden>
> Cc: Peter Maydell <address@hidden>
> Cc: Shannon Zhao <address@hidden>
> Cc: Xiao Guangrong <address@hidden>
> Cc: Stefan Hajnoczi <address@hidden>
> Signed-off-by: Corey Minyard <address@hidden>
Reviewed-by: Michael S. Tsirkin <address@hidden>
> ---
> hw/ipmi/ipmi_bmc_sim.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/ipmi/ipmi_bmc_sim.c b/hw/ipmi/ipmi_bmc_sim.c
> index 0a59e53..3ecf02e 100644
> --- a/hw/ipmi/ipmi_bmc_sim.c
> +++ b/hw/ipmi/ipmi_bmc_sim.c
> @@ -546,7 +546,7 @@ static void ipmi_init_sensors_from_sdrs(IPMIBmcSim *s)
> static int ipmi_register_netfn(IPMIBmcSim *s, unsigned int netfn,
> const IPMINetfn *netfnd)
> {
> - if ((netfn & 1) || (netfn > MAX_NETFNS) || (s->netfns[netfn / 2])) {
> + if ((netfn & 1) || (netfn >= MAX_NETFNS) || (s->netfns[netfn / 2])) {
> return -1;
> }
> s->netfns[netfn / 2] = netfnd;
> --
> 2.5.0
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [Qemu-devel] [PATCH 1/2] ipmi_bmc_sim: Fix off by one in check.,
Michael S. Tsirkin <=