[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] vl.c: remove duplicate call to qemu_get_machine
From: |
Laszlo Ersek |
Subject: |
Re: [Qemu-devel] [PATCH] vl.c: remove duplicate call to qemu_get_machine_opts |
Date: |
Mon, 8 Feb 2016 13:22:40 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 |
On 02/08/16 12:45, Marcel Apfelbaum wrote:
> Also we can use current machine properties instead of querying machine's opts.
Why? :) For me at least, you'll have to spell it out.
Thanks
Laszlo
>
> Signed-off-by: Marcel Apfelbaum <address@hidden>
> ---
> vl.c | 9 ++++-----
> 1 file changed, 4 insertions(+), 5 deletions(-)
>
> diff --git a/vl.c b/vl.c
> index 5873248..c03a4fe 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -4353,11 +4353,10 @@ int main(int argc, char **argv, char **envp)
> qtest_init(qtest_chrdev, qtest_log, &error_fatal);
> }
>
> - machine_opts = qemu_get_machine_opts();
> - kernel_filename = qemu_opt_get(machine_opts, "kernel");
> - initrd_filename = qemu_opt_get(machine_opts, "initrd");
> - kernel_cmdline = qemu_opt_get(machine_opts, "append");
> - bios_name = qemu_opt_get(machine_opts, "firmware");
> + kernel_filename = current_machine->kernel_filename;
> + initrd_filename = current_machine->initrd_filename;
> + kernel_cmdline = current_machine->kernel_cmdline;
> + bios_name = current_machine->firmware;
>
> opts = qemu_opts_find(qemu_find_opts("boot-opts"), NULL);
> if (opts) {
>
Thanks
Laszlo