[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v6 01/16] qom: add helpers for UserCreatable obj
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v6 01/16] qom: add helpers for UserCreatable object types |
Date: |
Thu, 11 Feb 2016 16:13:22 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 |
On 02/10/2016 11:40 AM, Daniel P. Berrange wrote:
> The QMP monitor code has two helper methods object_add
> and qmp_object_del that are called from several places
> in the code (QMP, HMP and main emulator startup).
>
> The HMP and main emulator startup code also share
> further logic that extracts the qom-type & id
> values from a qdict.
>
> We soon need to use this logic from qemu-img, qemu-io
> and qemu-nbd too, but don't want those to depend on
> the monitor, nor do we want to duplicate the code.
>
> To avoid this, move some code out of qmp.c and hmp.c
> adding new methods to qom/object_interfaces.c
>
> - user_creatable_add - takes a QDict holding a full
> object definition & instantiates it
> - user_creatable_add_type - takes an ID, type name,
> and QDict holding object properties & instantiates
> it
> - user_creatable_add_opts - takes a QemuOpts holding
> a full object definition & instantiates it
> - user_creatable_add_opts_foreach - variant on
> user_creatable_add_opts which can be directly used
> in conjunction with qemu_opts_foreach.
> - user_creatable_del - takes an ID and deletes the
> corresponding object
>
> The existing code is updated to use these new methods.
>
> Signed-off-by: Daniel P. Berrange <address@hidden>
> ---
> hmp.c | 52 +++---------
> include/monitor/monitor.h | 3 -
> include/qom/object_interfaces.h | 92 +++++++++++++++++++++
> qmp.c | 76 ++----------------
> qom/object_interfaces.c | 174
> ++++++++++++++++++++++++++++++++++++++++
> vl.c | 68 ++--------------
> 6 files changed, 290 insertions(+), 175 deletions(-)
>
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v6 00/16] Implement TLS support to QEMU NBD server & client, Daniel P. Berrange, 2016/02/10
- [Qemu-devel] [PATCH v6 02/16] qemu-nbd: add support for --object command line arg, Daniel P. Berrange, 2016/02/10
- [Qemu-devel] [PATCH v6 01/16] qom: add helpers for UserCreatable object types, Daniel P. Berrange, 2016/02/10
- Re: [Qemu-devel] [PATCH v6 01/16] qom: add helpers for UserCreatable object types,
Eric Blake <=
- [Qemu-devel] [PATCH v6 03/16] nbd: convert block client to use I/O channels for connection setup, Daniel P. Berrange, 2016/02/10
- [Qemu-devel] [PATCH v6 04/16] nbd: convert qemu-nbd server to use I/O channels for connection setup, Daniel P. Berrange, 2016/02/10
- [Qemu-devel] [PATCH v6 05/16] nbd: convert blockdev NBD server to use I/O channels for connection setup, Daniel P. Berrange, 2016/02/10
- [Qemu-devel] [PATCH v6 07/16] nbd: invert client logic for negotiating protocol version, Daniel P. Berrange, 2016/02/10
- [Qemu-devel] [PATCH v6 08/16] nbd: make server compliant with fixed newstyle spec, Daniel P. Berrange, 2016/02/10
- [Qemu-devel] [PATCH v6 09/16] nbd: make client request fixed new style if advertized, Daniel P. Berrange, 2016/02/10
- [Qemu-devel] [PATCH v6 10/16] nbd: allow setting of an export name for qemu-nbd server, Daniel P. Berrange, 2016/02/10
- [Qemu-devel] [PATCH v6 12/16] nbd: use "" as a default export name if none provided, Daniel P. Berrange, 2016/02/10
- [Qemu-devel] [PATCH v6 11/16] nbd: always query export list in fixed new style protocol, Daniel P. Berrange, 2016/02/10
- [Qemu-devel] [PATCH v6 06/16] nbd: convert to using I/O channels for actual socket I/O, Daniel P. Berrange, 2016/02/10