[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] net: check packet payload length
From: |
P J P |
Subject: |
Re: [Qemu-devel] [PATCH] net: check packet payload length |
Date: |
Thu, 18 Feb 2016 00:20:36 +0530 (IST) |
+-- On Wed, 17 Feb 2016, Markus Armbruster wrote --+
| Is calling this function with a partial IPv4 TCP/UDP packet legitimate?
| If partial packet is okay, what about a partial header?
Partial? That shouldn't harm I guess.
| If not, should we assert plen + hlen <= length? Or == length, even?
The proposed patch would handle that, no? Ie return if it's >= length.
Couple of places they check to ensure that length is > minimum packet length.
| If either is legit, are the callers that can do it prepared for the
| checksum not to be computed?
IIUC checksum is not always computed, only if it's requested.
| Style nitpick: we generally omit obviously superfluous parenthesis.
Okay. Should I resend it?
Thank you.
--
Prasad J Pandit / Red Hat Product Security Team
47AF CE69 3A90 54AA 9045 1053 DD13 3D32 FE5B 041F
- [Qemu-devel] [PATCH] net: check packet payload length, P J P, 2016/02/17
- Re: [Qemu-devel] [PATCH] net: check packet payload length, Markus Armbruster, 2016/02/17
- Re: [Qemu-devel] [PATCH] net: check packet payload length,
P J P <=
- Re: [Qemu-devel] [PATCH] net: check packet payload length, P J P, 2016/02/18
- Re: [Qemu-devel] [PATCH] net: check packet payload length, Markus Armbruster, 2016/02/18
- Re: [Qemu-devel] [PATCH] net: check packet payload length, P J P, 2016/02/18
- Re: [Qemu-devel] [PATCH] net: check packet payload length, Jason Wang, 2016/02/23
- Re: [Qemu-devel] [PATCH] net: check packet payload length, P J P, 2016/02/23
- Re: [Qemu-devel] [PATCH] net: check packet payload length, Jason Wang, 2016/02/23
- Re: [Qemu-devel] [PATCH] net: check packet payload length, P J P, 2016/02/23