[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL 07/13] msix: fix msix_vector_masked
From: |
Stefano Stabellini |
Subject: |
Re: [Qemu-devel] [PULL 07/13] msix: fix msix_vector_masked |
Date: |
Fri, 19 Feb 2016 12:29:19 +0000 |
User-agent: |
Alpine 2.02 (DEB 1266 2009-07-14) |
On Fri, 19 Feb 2016, Peter Maydell wrote:
> On 19 February 2016 at 12:18, Stefano Stabellini
> <address@hidden> wrote:
> > On Fri, 19 Feb 2016, Michael S. Tsirkin wrote:
> >> commit 428c3ece97179557f2753071fb0ca97a03437267 ("fix MSI injection on
> >> Xen")
> >> inadvertently enabled the xen-specific logic unconditionally.
> >> Limit it to only when xen is enabled.
> >> Additionally, msix data should be read with pci_get_log
> >> since the format is pci little-endian.
> >>
> >> Reported-by: "Daniel P. Berrange" <address@hidden>
> >> Cc: Stefano Stabellini <address@hidden>
> >> Signed-off-by: Michael S. Tsirkin <address@hidden>
> >
> > the follow up patch is missing from the pull request:
> >
> > http://marc.info/?l=xen-devel&m=145553838801725&w=2
>
> does this mean I should prefer not to apply the pull, or can
> that patch be committed later ?
I would have preferred the two patches to go in together, but I wouldn't
want to delay Michael's fix. If he is not around to respin the pull
request today, I'd say go ahead and commit it anyway.
- [Qemu-devel] [PULL 00/13] vhost, virtio, pci, pxe, Michael S. Tsirkin, 2016/02/19
- [Qemu-devel] [PULL 01/13] virtio-net: use the backend cross-endian capabilities, Michael S. Tsirkin, 2016/02/19
- [Qemu-devel] [PULL 02/13] vhost-net: revert support of cross-endian vnet headers, Michael S. Tsirkin, 2016/02/19
- [Qemu-devel] [PULL 03/13] virtio: move cross-endian helper to vhost, Michael S. Tsirkin, 2016/02/19
- [Qemu-devel] [PULL 05/13] vhost: simplify vhost_needs_vring_endian(), Michael S. Tsirkin, 2016/02/19
- [Qemu-devel] [PULL 04/13] vhost: move virtio 1.0 check to cross-endian helper, Michael S. Tsirkin, 2016/02/19
- [Qemu-devel] [PULL 06/13] virtio: optimize virtio_access_is_big_endian() for little-endian targets, Michael S. Tsirkin, 2016/02/19
- [Qemu-devel] [PULL 07/13] msix: fix msix_vector_masked, Michael S. Tsirkin, 2016/02/19
- [Qemu-devel] [PULL 08/13] tests: add pxe e1000 and virtio-pci tests, Michael S. Tsirkin, 2016/02/19
- [Qemu-devel] [PULL 09/13] dec: convert to realize(), Michael S. Tsirkin, 2016/02/19
- [Qemu-devel] [PULL 10/13] change type of pci_bridge_initfn() to void, Michael S. Tsirkin, 2016/02/19
- [Qemu-devel] [PULL 11/13] rules: filter out irrelevant files, Michael S. Tsirkin, 2016/02/19
- [Qemu-devel] [PULL 12/13] vhost-user interrupt management fixes, Michael S. Tsirkin, 2016/02/19
- [Qemu-devel] [PULL 13/13] tests/vhost-user-bridge: add scattering of incoming packets, Michael S. Tsirkin, 2016/02/19
- Re: [Qemu-devel] [PULL 00/13] vhost, virtio, pci, pxe, Peter Maydell, 2016/02/19
- Re: [Qemu-devel] [PULL 00/13] vhost, virtio, pci, pxe, Samuel Thibault, 2016/02/19
- Re: [Qemu-devel] [PULL 00/13] vhost, virtio, pci, pxe, Peter Maydell, 2016/02/19