[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 1/1] quorum: modify vote rules for flush oper
From: |
Alberto Garcia |
Subject: |
Re: [Qemu-devel] [PATCH v3 1/1] quorum: modify vote rules for flush operation |
Date: |
Mon, 22 Feb 2016 15:33:23 +0100 |
User-agent: |
Notmuch/0.13.2 (http://notmuchmail.org) Emacs/23.2.1 (i486-pc-linux-gnu) |
On Mon 22 Feb 2016 10:50:37 AM CET, Changlong Xie wrote:
> - winner = quorum_get_vote_winner(&error_votes);
> - result = winner->value.l;
> -
> + if (success_count >= s->threshold)
> + result = 0;
> + else {
> + winner = quorum_get_vote_winner(&error_votes);
> + result = winner->value.l;
> + }
Please use braces in both branches of the if. scripts/checkpatch.pl
should report that.
Other than that I think the patch is correct, but I still wonder if we
should emit QUORUM_REPORT_BAD (or a new event) for the operations that
fail. Or why wouldn't the user want to be notified of a flush failure?
Berto