[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCHv9 04/10] slirp: Factorizing tcpiphdr structure w
From: |
Thomas Huth |
Subject: |
Re: [Qemu-devel] [PATCHv9 04/10] slirp: Factorizing tcpiphdr structure with an union |
Date: |
Tue, 23 Feb 2016 09:07:11 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 |
On 22.02.2016 20:28, Samuel Thibault wrote:
> From: Guillaume Subiron <address@hidden>
>
> This patch factorizes the tcpiphdr structure to put the IPv4 fields in
> an union, for addition of version 6 in further patch.
> Using some macros, retrocompatibility of the existing code is assured.
>
> This patch also fixes the SLIRP_MSIZE and margin computation in various
> functions, and makes them compatible with the new tcpiphdr structure,
> whose size will be bigger than sizeof(struct tcphdr) + sizeof(struct ip)
>
> Signed-off-by: Guillaume Subiron <address@hidden>
> Signed-off-by: Samuel Thibault <address@hidden>
> ---
> slirp/if.h | 4 ++--
> slirp/mbuf.c | 4 ++--
> slirp/slirp.c | 15 ++++++++-------
> slirp/socket.c | 13 ++++++++++++-
> slirp/tcp_input.c | 31 ++++++++++++++++++++-----------
> slirp/tcp_output.c | 18 +++++++++++++-----
> slirp/tcp_subr.c | 31 ++++++++++++++++++++++---------
> slirp/tcpip.h | 31 +++++++++++++++++++++++--------
> 8 files changed, 102 insertions(+), 45 deletions(-)
Sounds reasonable to me now.
Reviewed-by: Thomas Huth <address@hidden>
- [Qemu-devel] [PATCHv9 0/10] slirp: Adding IPv6 support to Qemu -net user mode, Samuel Thibault, 2016/02/22
- [Qemu-devel] [PATCHv9 03/10] slirp: Adding IPv6 UDP support, Samuel Thibault, 2016/02/22
- [Qemu-devel] [PATCHv9 10/10] slirp: Add IPv6 support to the TFTP code, Samuel Thibault, 2016/02/22
- [Qemu-devel] [PATCHv9 08/10] slirp: Adding IPv6 address for DNS relay, Samuel Thibault, 2016/02/22
- [Qemu-devel] [PATCHv9 06/10] slirp: Reindent after refactoring, Samuel Thibault, 2016/02/22
- [Qemu-devel] [PATCHv9 09/10] qapi-schema, qemu-options & slirp: Adding Qemu options for IPv6 addresses, Samuel Thibault, 2016/02/22
- [Qemu-devel] [PATCHv9 07/10] slirp: Handle IPv6 in TCP functions, Samuel Thibault, 2016/02/22
- [Qemu-devel] [PATCHv9 04/10] slirp: Factorizing tcpiphdr structure with an union, Samuel Thibault, 2016/02/22
- Re: [Qemu-devel] [PATCHv9 04/10] slirp: Factorizing tcpiphdr structure with an union,
Thomas Huth <=
- [Qemu-devel] [PATCHv9 02/10] slirp: Adding ICMPv6 error sending, Samuel Thibault, 2016/02/22
- [Qemu-devel] [PATCHv9 05/10] slirp: Generalizing and neutralizing various TCP functions before adding IPv6 stuff, Samuel Thibault, 2016/02/22
- [Qemu-devel] [PATCHv9 01/10] slirp: Adding IPv6, ICMPv6 Echo and NDP autoconfiguration, Samuel Thibault, 2016/02/22