Re: [Qemu-devel] [PATCH] net: ne2000: check ring buffer control registers

[P J P]

+-- On Wed, 24 Feb 2016, Jason Wang wrote --+
| Right, but since setting STARTPG,STOPPG,BOUNDARY and CURPAG is not
| atomic. Try to limit it during value setting is hard to be correct.

  I see.
 
| Then let's return true when s->stop <= s->start?

  Okay. Though I'm not sure if it's the right place for it, because more than 
buffer is full, it says buffer does not exist.
 
| It's really hard to say there's no such driver. Which means if there's
| such a driver and it works on real hardware, we need make it work for qemu.

  I guess better would be to see if the hardware standard specifies such an 
interface for the driver. I did not find it mentioned anywhere; Even kernel 
drivers have it fixed.

I'll send a revised patch for ne2000_buffer_full().
--
 - P J P
47AF CE69 3A90 54AA 9045 1053 DD13 3D32 FE5B 041F