[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] qga: fix w32 breakage due to missing osdep.h in
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH] qga: fix w32 breakage due to missing osdep.h includes |
Date: |
Wed, 24 Feb 2016 18:13:42 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 |
On 02/24/2016 06:01 PM, Michael Roth wrote:
> requester.h relied on qemu/compiler.h definitions to
> handle GCC_FMT_ATTR() stub, but this include was removed as part
> of scripted clean-ups via 30456d5:
>
> all: Clean up includes
>
> under the assumption that all C files would have included it via
> qemu/osdep.h at that point. requester.cpp was likely missed
> due to C++ files requiring manual/special handling as well as
> VSS build options needing to be enabled to trigger build failures.
>
> Fix this by including qemu/osdep.h. That in turn pulls in a
> macro from qapi/error.h that conflicts with a struct field name
> in requester.h, so fix that as well by renaming the field.
>
> While we're at it, fix up provider.cpp/install.cpp to include
> osdep.h as well.
>
> Cc: Peter Maydell <address@hidden>
> Signed-off-by: Michael Roth <address@hidden>
> ---
Reviewed-by: Eric Blake <address@hidden>
(but I'm not set up to provide Tested-by on this one)
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature