Re: [Qemu-devel] [PATCH] loader: fix potential memory leak

[Cao jin]

sorry, It just came to me that I forgot to cc qemu-trivial

On 02/24/2016 05:12 PM, Cao jin wrote:
> Signed-off-by: Cao jin <address@hidden>
> ---
>   hw/core/loader.c | 6 ++++++
>   1 file changed, 6 insertions(+)
>
> diff --git a/hw/core/loader.c b/hw/core/loader.c
> index 3a57415..24fea65 100644
> --- a/hw/core/loader.c
> +++ b/hw/core/loader.c
> @@ -827,10 +827,16 @@ int rom_add_file(const char *file, const char *fw_dir,
>   err:
>       if (fd != -1)
>           close(fd);
> +
>       g_free(rom->data);
>       g_free(rom->path);
>       g_free(rom->name);
> +    if (fw_dir) {
> +        g_free(rom->fw_dir);
> +        g_free(rom->fw_file);
> +    }
>       g_free(rom);
> +
>       return -1;
>   }

--
Yours Sincerely,

Cao jin