[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v3 01/15] backup: Use Bitmap to replace "s->bitmap"
From: |
Fam Zheng |
Subject: |
[Qemu-devel] [PATCH v3 01/15] backup: Use Bitmap to replace "s->bitmap" |
Date: |
Sat, 27 Feb 2016 17:20:43 +0800 |
"s->bitmap" tracks done sectors, we only check bit states without using any
iterator which HBitmap is good for. Switch to "Bitmap" which is simpler and
more memory efficient.
Meanwhile, rename it to done_bitmap, to reflect the intention.
Signed-off-by: Fam Zheng <address@hidden>
Reviewed-by: John Snow <address@hidden>
---
block/backup.c | 11 ++++++-----
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/block/backup.c b/block/backup.c
index 00cafdb..c6c1b81 100644
--- a/block/backup.c
+++ b/block/backup.c
@@ -20,6 +20,7 @@
#include "qapi/qmp/qerror.h"
#include "qemu/ratelimit.h"
#include "sysemu/block-backend.h"
+#include "qemu/bitmap.h"
#define BACKUP_CLUSTER_BITS 16
#define BACKUP_CLUSTER_SIZE (1 << BACKUP_CLUSTER_BITS)
@@ -45,7 +46,7 @@ typedef struct BackupBlockJob {
BlockdevOnError on_target_error;
CoRwlock flush_rwlock;
uint64_t sectors_read;
- HBitmap *bitmap;
+ unsigned long *done_bitmap;
QLIST_HEAD(, CowRequest) inflight_reqs;
} BackupBlockJob;
@@ -111,7 +112,7 @@ static int coroutine_fn backup_do_cow(BlockDriverState *bs,
cow_request_begin(&cow_request, job, start, end);
for (; start < end; start++) {
- if (hbitmap_get(job->bitmap, start)) {
+ if (test_bit(start, job->done_bitmap)) {
trace_backup_do_cow_skip(job, start);
continue; /* already copied */
}
@@ -162,7 +163,7 @@ static int coroutine_fn backup_do_cow(BlockDriverState *bs,
goto out;
}
- hbitmap_set(job->bitmap, start, 1);
+ set_bit(start, job->done_bitmap);
/* Publish progress, guest I/O counts as progress too. Note that the
* offset field is an opaque progress value, it is not a disk offset.
@@ -392,7 +393,7 @@ static void coroutine_fn backup_run(void *opaque)
start = 0;
end = DIV_ROUND_UP(job->common.len, BACKUP_CLUSTER_SIZE);
- job->bitmap = hbitmap_alloc(end, 0);
+ job->done_bitmap = bitmap_new(end);
bdrv_set_enable_write_cache(target, true);
if (target->blk) {
@@ -473,7 +474,7 @@ static void coroutine_fn backup_run(void *opaque)
/* wait until pending backup_do_cow() calls have completed */
qemu_co_rwlock_wrlock(&job->flush_rwlock);
qemu_co_rwlock_unlock(&job->flush_rwlock);
- hbitmap_free(job->bitmap);
+ g_free(job->done_bitmap);
if (target->blk) {
blk_iostatus_disable(target->blk);
--
2.4.3
- [Qemu-devel] [PATCH v3 00/15] Dirty bitmap changes for migration/persistence work, Fam Zheng, 2016/02/27
- [Qemu-devel] [PATCH v3 01/15] backup: Use Bitmap to replace "s->bitmap",
Fam Zheng <=
- [Qemu-devel] [PATCH v3 02/15] block: Include hbitmap.h in block.h, Fam Zheng, 2016/02/27
- [Qemu-devel] [PATCH v3 03/15] typedefs: Add BdrvDirtyBitmap, Fam Zheng, 2016/02/27
- [Qemu-devel] [PATCH v3 05/15] block: Remove unused typedef of BlockDriverDirtyHandler, Fam Zheng, 2016/02/27
- [Qemu-devel] [PATCH v3 04/15] block: Move block dirty bitmap code to separate files, Fam Zheng, 2016/02/27
- [Qemu-devel] [PATCH v3 06/15] block: Hide HBitmap in block dirty bitmap interface, Fam Zheng, 2016/02/27
- [Qemu-devel] [PATCH v3 07/15] HBitmap: Introduce "meta" bitmap to track bit changes, Fam Zheng, 2016/02/27
- [Qemu-devel] [PATCH v3 08/15] tests: Add test code for meta bitmap, Fam Zheng, 2016/02/27
- [Qemu-devel] [PATCH v3 09/15] block: Support meta dirty bitmap, Fam Zheng, 2016/02/27