Re: [Qemu-devel] [PATCH v3 09/10] chardev: Drop useless ChardevDummy type

[Markus Armbruster]

Eric Blake <address@hidden> writes:

> Commit d0d7708b made ChardevDummy be an empty wrapper type around
> ChardevCommon.  But there is no technical reason for this indirection,
> so simplify the code by directly using the base type.
>
> Also change the fallback assignment to assign u.null rather than
> u.data, since a future patch will remove the data member of the C
> struct generated for QAPI unions.
>
> Signed-off-by: Eric Blake <address@hidden>
> Reviewed-by: Daniel P. Berrange <address@hidden>

Doesn't compile with MinGW:

qemu/qemu-char.c: In function 'qemu_chr_open_win_con':
qemu/qemu-char.c:2186:29: warning: implicit declaration of function 
'qapi_ChardevDummy_base' [-Wimplicit-function-declaration]
     ChardevCommon *common = qapi_ChardevDummy_base(backend->u.console);
                             ^
qemu/qemu-char.c:2186:5: warning: nested extern declaration of 
'qapi_ChardevDummy_base' [-Wnested-externs]
     ChardevCommon *common = qapi_ChardevDummy_base(backend->u.console);
     ^
qemu/qemu-char.c:2186:29: warning: initialization makes pointer from integer 
without a cast [-Wint-conversion]
     ChardevCommon *common = qapi_ChardevDummy_base(backend->u.console);
                             ^