Re: [Qemu-devel] [PATCH v8 5/9] qemu-log: new option -dfilter to limit output

[Richard Henderson]

On 03/04/2016 03:18 AM, Alex Bennée wrote:
> +                case '+':
> +                {
> +                    unsigned long len;
> +                    err |= qemu_strtoull(r2, NULL, 0, &len);
> +                    if (len > 0) {
> +                        range.end = range.begin + (len - 1);
> +                    } else {
> +                        err |= true;
> +                    }
> +                    break;
> +                }
> +                case '-':
> +                {
> +                    unsigned long len;
> +                    err |= qemu_strtoull(r2, NULL, 0, &len);
> +                    range.end = range.begin;
> +                    range.begin = range.end - len;
> +                    break;
> +                }

Doesn't '-' have the same off-by-one bug?
Although really I don't understand the need for negative ranges...


r~