Re: [Qemu-devel] [PATCH v2 3/7] target-tricore: add add.f/sub.f instructions

[Richard Henderson]

On 03/08/2016 12:42 PM, Bastian Koppelmann wrote:
> +    arg1 = float32_squash_input_denormal(arg1, &env->fp_status);               
> \
> +    arg2 = float32_squash_input_denormal(arg2, &env->fp_status);               
> \
> +                                                                               
> \
> +    f_result = float32_##op(arg2, arg1, &env->fp_status);                      
> \
> +    flags = f_get_excp_flags(env);                                             
> \
> +    if (flags) {                                                               
> \

float32_squash_input_denormal is the first thing that float32_##op does.  No 
need to repeat that here.

Otherwise,

Reviewed-by: Richard Henderson <address@hidden>


r~