Re: [Qemu-devel] [PATCH 3/9] hw/arm: QOM'ify integratorcp.c

[Peter Maydell]

On 7 March 2016 at 07:05, xiaoqiang zhao <address@hidden> wrote:
> * Drop the use of old SysBus init function and use instance_init
> * Remove the empty 'icp_pic_class_init' from Typeinfo
>
> Signed-off-by: xiaoqiang zhao <address@hidden>

Reviewed-by: Peter Maydell <address@hidden>

Possible follow-up cleanups:
 * move the integrator_pic code into hw/intc/integrator_pic.c
 * move the icp-ctrl-regs code into hw/misc/integrator_control.c
 * move the integrator_core code into hw/misc/integrator_core.c
 * implement reset methods for these devices
 * implement migration state via a VMState struct for these devices

thanks
-- PMM