|
| From: | Richard Henderson |
| Subject: | Re: [Qemu-devel] [PATCH v2 06/13] qemu-thread: add simple test-and-set spinlock |
| Date: | Fri, 8 Apr 2016 11:38:11 -0700 |
| User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.1 |
On 04/08/2016 06:02 AM, Alex Bennée wrote:
>> > +typedef struct QemuSpin {
>> > + int value;
> If we are throwing true and false around as the only two values can we
> use bool here and be consistent when setting/clearing.
>
Except that quite a lot of hosts can only (efficiently) do atomic operations on
a minimum of 4 byte quantities. I'd rather continue to use int here.
r~
| [Prev in Thread] | Current Thread | [Next in Thread] |