Re: [Qemu-devel] [PATCH 46/52] target-m68k: introduce byte and word cc_ops

[Richard Henderson]

On 05/04/2016 11:21 AM, Laurent Vivier wrote:
> Signed-off-by: Laurent Vivier <address@hidden>
> ---
>  target-m68k/cpu.h       |  6 +--
>  target-m68k/helper.c    | 25 +++++++++----
>  target-m68k/translate.c | 99 ++++++++++++++++++++++++++++++-------------------
>  3 files changed, 80 insertions(+), 50 deletions(-)

I think this ought to be merged back with the other cc_ops patches.

> @@ -864,7 +881,6 @@ static void gen_cc_cond(DisasCompare *c, DisasContext *s, 
> int cond)
>          c->v1 = c->v2;
>          tcond = TCG_COND_NEVER;
>          goto done;
> -    case 14: /* GT (!(Z || (N ^ V))) */
>      case 15: /* LE (Z || (N ^ V)) */
>          /* Logic operations clear V, which simplifies LE to (Z || N),
>             and since Z and N are co-located, this becomes a normal

What happened here?


r~