Re: [Qemu-devel] [PATCH] cpu-exec: Clean up 'interrupt_request' reloading in cpu_handle_interrupt()

[Richard Henderson]

On 05/12/2016 04:14 AM, Sergey Fedorov wrote:
> @@ -489,9 +489,10 @@ static inline void cpu_handle_interrupt(CPUState *cpu,
>                  *last_tb = NULL;
>              }

[A]

>          }
> -        /* Don't use the cached interrupt_request value,
> -           do_interrupt may have updated the EXITTB flag. */
> -        if (cpu->interrupt_request & CPU_INTERRUPT_EXITTB) {
> +        /* The target hook may have updated the 'cpu->interrupt_request';
> +         * reload the 'interrupt_request' value */
> +        interrupt_request = cpu->interrupt_request;
> +        if (interrupt_request & CPU_INTERRUPT_EXITTB) {

Actually I suggested reloading it after the only place it could have changed, 
at A.


r~