Re: [Qemu-devel] [PATCH v2 1/9] log: Add new IOMMU type

[Auger Eric]

Hi Prem,

Missing commit message

> Signed-off-by: Prem Mallappa <address@hidden>
> ---
>  include/qemu/log.h | 1 +
>  util/log.c         | 2 ++
>  2 files changed, 3 insertions(+)
> 
> diff --git a/include/qemu/log.h b/include/qemu/log.h
> index 234fa81..3dd2131 100644
> --- a/include/qemu/log.h
> +++ b/include/qemu/log.h
> @@ -42,6 +42,7 @@ static inline bool qemu_log_separate(void)
>  #define CPU_LOG_TB_NOCHAIN (1 << 13)
>  #define CPU_LOG_PAGE       (1 << 14)
>  #define LOG_TRACE          (1 << 15)
> +#define CPU_LOG_IOMMU      (1 << 16)
why is it prefixed with CPU_ ?
besides all arm gic devices seem to use LOG_GUEST_ERROR. what is the
rationale behind introducing a new enum?

Thanks

Eric
>  
>  /* Returns true if a bit is set in the current loglevel mask
>   */
> diff --git a/util/log.c b/util/log.c
> index 5ad72c1..62c4378 100644
> --- a/util/log.c
> +++ b/util/log.c
> @@ -241,6 +241,8 @@ const QEMULogItem qemu_log_items[] = {
>        "show CPU registers before entering a TB (lots of logs)" },
>      { CPU_LOG_MMU, "mmu",
>        "log MMU-related activities" },
> +    { CPU_LOG_IOMMU, "iommu",
> +      "log IOMMU-related activities" },
>      { CPU_LOG_PCALL, "pcall",
>        "x86 only: show protected mode far calls/returns/exceptions" },
>      { CPU_LOG_RESET, "cpu_reset",
>