[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 3/6] qdev: Register static properties as clas
From: |
Eduardo Habkost |
Subject: |
Re: [Qemu-devel] [PATCH v2 3/6] qdev: Register static properties as class properties |
Date: |
Wed, 26 Oct 2016 13:59:17 -0200 |
User-agent: |
Mutt/1.7.0 (2016-08-17) |
On Wed, Oct 26, 2016 at 05:02:22PM +0200, Igor Mammedov wrote:
> On Thu, 20 Oct 2016 15:47:56 -0200
> Eduardo Habkost <address@hidden> wrote:
>
> > Instead of registering qdev static properties on instance_init,
> > register them as class properties, at qdev_class_set_props().
> >
> > qdev_property_add_legacy() was replaced by an equivalent
> > qdev_class_property_add_legacy() function.
> > qdev_property_add_static(), on the other hand, can't be
> > eliminated yet because it is used by arm_cpu_post_init().
> >
> > Signed-off-by: Eduardo Habkost <address@hidden>
> on make check, I'm getting after
> [1/1 has been regenerated using script from commit message]
>
>
> hw/core/qdev.c:1063: device_class_set_props: Assertion `!dc->props' failed.
>
This series depends on "tests: A few check-qom-proplist fixes"
series. See cover letter for git pointer.
When submitting a new version, I will include both in a single
series.
--
Eduardo
- [Qemu-devel] [PATCH v2 0/6] qdev class properties + abstract class support on device-list-properties, Eduardo Habkost, 2016/10/20
- [Qemu-devel] [PATCH v2 2/6] qdev: Extract property-default code to qdev_property_set_to_default(), Eduardo Habkost, 2016/10/20
- [Qemu-devel] [PATCH v2 3/6] qdev: Register static properties as class properties, Eduardo Habkost, 2016/10/20
- [Qemu-devel] [PATCH v2 4/6] qom: object_class_property_iter_init() function, Eduardo Habkost, 2016/10/20
- [Qemu-devel] [PATCH v2 5/6] qmp: Support abstract classes on device-list-properties, Eduardo Habkost, 2016/10/20
- [Qemu-devel] [PATCH v2 6/6] qdev: Warning about using object_class_property_add() in new code, Eduardo Habkost, 2016/10/20
- [Qemu-devel] [PATCH v2 1/6] qdev: device_class_set_props() function, Eduardo Habkost, 2016/10/20
- Re: [Qemu-devel] [PATCH v2 0/6] qdev class properties + abstract class support on device-list-properties, no-reply, 2016/10/20