qemu-devel
[Top][All Lists]
Advanced
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PULL for-2.8 0/9] tcg updates

From: Richard Henderson
Subject: Re: [Qemu-devel] [PULL for-2.8 0/9] tcg updates
Date: Mon, 31 Oct 2016 10:57:09 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 
On 10/31/2016 10:40 AM, Peter Maydell wrote:

I'm afraid this doesn't build on w32:

In file included from ./trace/generated-tracers.h:5980:0,
                 from /home/petmay01/linaro/qemu-for-merges/include/trace.h:4,
                 from
/home/petmay01/linaro/qemu-for-merges/qapi/qapi-visit-core.c:22:
/home/petmay01/linaro/qemu-for-merges/include/qemu/log.h: In function
‘qemu_log_lock’:
/home/petmay01/linaro/qemu-for-merges/include/qemu/log.h:62:5: error:
implicit declaration of function ‘flockfile’
[-Werror=implicit-function-declaration]
     flockfile(qemu_logfile);
     ^


Ho hum.  Mingw seems to have

  _CRTIMP void __cdecl _lock_file(FILE *_File);
  _CRTIMP void __cdecl _unlock_file(FILE *_File);
for no apparent good reason. Shall I attempt to hide this detail within sysemu/os-*? As qemu_flockfile, presumably? 


r~
reply via email to
[Prev in Thread] Current Thread [Next in Thread]