[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL v2 05/14] block: Turn on "unmap" in active commit
From: |
Jeff Cody |
Subject: |
[Qemu-devel] [PULL v2 05/14] block: Turn on "unmap" in active commit |
Date: |
Tue, 1 Nov 2016 08:51:02 -0400 |
From: Fam Zheng <address@hidden>
We already specified BDRV_O_UNMAP when opening images in 'qemu-img
commit', but didn't turn on the "unmap" in the active commit job. This
patch fixes that so that zeroed clusters in top image can be discarded
which is desired in the virt-sparsify use case, where a temporary
overlay is created and fstrim'ed before commiting back, to free space in
the original image.
This also enables it for block-commit.
Signed-off-by: Fam Zheng <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Message-id: address@hidden
Signed-off-by: Jeff Cody <address@hidden>
---
block/mirror.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/block/mirror.c b/block/mirror.c
index 7e99f3a..82a9529 100644
--- a/block/mirror.c
+++ b/block/mirror.c
@@ -1081,7 +1081,7 @@ void commit_active_start(const char *job_id,
BlockDriverState *bs,
mirror_start_job(job_id, bs, base, NULL, speed, 0, 0,
MIRROR_LEAVE_BACKING_CHAIN,
- on_error, on_error, false, cb, opaque, &local_err,
+ on_error, on_error, true, cb, opaque, &local_err,
&commit_active_job_driver, false, base, auto_complete);
if (local_err) {
error_propagate(errp, local_err);
--
2.7.4
- [Qemu-devel] [PULL v2 00/14] Block patches for 2.8, Jeff Cody, 2016/11/01
- [Qemu-devel] [PULL v2 02/14] rbd: make the code more readable, Jeff Cody, 2016/11/01
- [Qemu-devel] [PULL v2 01/14] qapi: add release designator to gluster logfile option, Jeff Cody, 2016/11/01
- [Qemu-devel] [PULL v2 05/14] block: Turn on "unmap" in active commit,
Jeff Cody <=
- [Qemu-devel] [PULL v2 04/14] block/gluster: memory usage: use one glfs instance per volume, Jeff Cody, 2016/11/01
- [Qemu-devel] [PULL v2 07/14] block/gluster: fix port type in the QAPI options list, Jeff Cody, 2016/11/01
- [Qemu-devel] [PULL v2 03/14] block: add gluster ifdef guard checks for SEEK_DATA/SEEK_HOLE support, Jeff Cody, 2016/11/01
- [Qemu-devel] [PULL v2 06/14] block/gluster: improve defense over string to int conversion, Jeff Cody, 2016/11/01
- [Qemu-devel] [PULL v2 08/14] blockjobs: hide internal jobs from management API, Jeff Cody, 2016/11/01
- [Qemu-devel] [PULL v2 10/14] Replication/Blockjobs: Create replication jobs as internal, Jeff Cody, 2016/11/01
- [Qemu-devel] [PULL v2 12/14] Blockjobs: Internalize user_pause logic, Jeff Cody, 2016/11/01
- [Qemu-devel] [PULL v2 09/14] blockjobs: Allow creating internal jobs, Jeff Cody, 2016/11/01
- [Qemu-devel] [PULL v2 14/14] blockjobs: fix documentation, Jeff Cody, 2016/11/01
- [Qemu-devel] [PULL v2 11/14] blockjob: centralize QMP event emissions, Jeff Cody, 2016/11/01