[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL v2 00/30] Misc patches for 2016-10-31
From: |
no-reply |
Subject: |
Re: [Qemu-devel] [PULL v2 00/30] Misc patches for 2016-10-31 |
Date: |
Tue, 1 Nov 2016 10:39:02 -0700 (PDT) |
Hi,
Your series seems to have some coding style problems. See output below for
more information:
Type: series
Subject: [Qemu-devel] [PULL v2 00/30] Misc patches for 2016-10-31
Message-id: address@hidden
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0
# Useful git options
git config --local diff.renamelimit 0
git config --local diff.renames True
commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
echo "Checking PATCH $n/$total: $(git show --no-patch --format=%s $c)..."
if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
failed=1
echo
fi
n=$((n+1))
done
exit $failed
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
* [new tag] patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
faf292f main-loop: Suppress I/O thread warning under qtest
3fe8c60 docs/rcu.txt: Fix minor typo
d32538f vl: exit qemu on guest panic if -no-shutdown is not set
031d388 checkpatch: allow spaces before parenthesis for 'coroutine_fn'
d9ab8bb x86: add AVX512_4VNNIW and AVX512_4FMAPS features
584e354 slirp: fix CharDriver breakage
d7e7fa4 qemu-char: do not forward events through the mux until QEMU has started
924fea8 nbd: Implement NBD_CMD_WRITE_ZEROES on client
6b5ee21 nbd: Implement NBD_CMD_WRITE_ZEROES on server
f032e48 nbd: Improve server handling of shutdown requests
486ffc6 nbd: Refactor conversion to errno to silence checkpatch
f698de1 nbd: Support shorter handshake
ec7f3de nbd: Less allocation during NBD_OPT_LIST
71e470c nbd: Let client skip portions of server reply
eb8e4b4 nbd: Let server know when client gives up negotiation
4f58cc8 nbd: Share common option-sending code in client
c919458 nbd: Send message along with server NBD_REP_ERR errors
b76fe64 nbd: Share common reply-sending code in server
afa213c nbd: Rename struct nbd_request and nbd_reply
4cb63fc nbd: Rename NbdClientSession to NBDClientSession
3828fb9 nbd: Rename NBDRequest to NBDRequestData
9bf69c9 nbd: Treat flags vs. command type as separate fields
a2d3af6 nbd: Add qemu-nbd -D for human-readable description
aef3582 exec.c: check memory backend file size with 'size' option
25a5c4b exec.c: do not truncate non-empty memory backend file
3c4f049 exec.c: ensure all AddressSpaceDispatch updates under RCU
bb0a1f3 tests: send error_report to test log
0916440 qemu-error: remove dependency of stubs on monitor
a6f8da9 nbd: Use CoQueue for free_sema instead of CoMutex
c22e47a checkpatch: tweak "struct should normally be const" warning
=== OUTPUT BEGIN ===
fatal: unrecognized argument: --no-patch
Checking PATCH 1/30: ...
WARNING: line over 80 characters
#29: FILE: scripts/checkpatch.pl:2502:
+ ERROR("initializer for struct $1 should normally be
const\n" .
total: 0 errors, 1 warnings, 10 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
fatal: unrecognized argument: --no-patch
Checking PATCH 2/30: ...
fatal: unrecognized argument: --no-patch
Checking PATCH 3/30: ...
fatal: unrecognized argument: --no-patch
Checking PATCH 4/30: ...
fatal: unrecognized argument: --no-patch
Checking PATCH 5/30: ...
WARNING: line over 80 characters
#27: FILE: exec.c:496:
+ AddressSpaceDispatch *d =
atomic_rcu_read(&cpu->cpu_ases[asidx].memory_dispatch);
total: 0 errors, 1 warnings, 16 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
fatal: unrecognized argument: --no-patch
Checking PATCH 6/30: ...
fatal: unrecognized argument: --no-patch
Checking PATCH 7/30: ...
fatal: unrecognized argument: --no-patch
Checking PATCH 8/30: ...
fatal: unrecognized argument: --no-patch
Checking PATCH 9/30: ...
fatal: unrecognized argument: --no-patch
Checking PATCH 10/30: ...
fatal: unrecognized argument: --no-patch
Checking PATCH 11/30: ...
fatal: unrecognized argument: --no-patch
Checking PATCH 12/30: ...
fatal: unrecognized argument: --no-patch
Checking PATCH 13/30: ...
fatal: unrecognized argument: --no-patch
Checking PATCH 14/30: ...
fatal: unrecognized argument: --no-patch
Checking PATCH 15/30: ...
fatal: unrecognized argument: --no-patch
Checking PATCH 16/30: ...
fatal: unrecognized argument: --no-patch
Checking PATCH 17/30: ...
fatal: unrecognized argument: --no-patch
Checking PATCH 18/30: ...
fatal: unrecognized argument: --no-patch
Checking PATCH 19/30: ...
fatal: unrecognized argument: --no-patch
Checking PATCH 20/30: ...
fatal: unrecognized argument: --no-patch
Checking PATCH 21/30: ...
fatal: unrecognized argument: --no-patch
Checking PATCH 22/30: ...
fatal: unrecognized argument: --no-patch
Checking PATCH 23/30: ...
fatal: unrecognized argument: --no-patch
Checking PATCH 24/30: ...
fatal: unrecognized argument: --no-patch
Checking PATCH 25/30: ...
fatal: unrecognized argument: --no-patch
Checking PATCH 26/30: ...
WARNING: line over 80 characters
#75: FILE: target-i386/cpu.h:633:
+#define CPUID_7_0_EDX_AVX512_4VNNIW (1U << 2) /* AVX512 Neural Network
Instructions */
ERROR: line over 90 characters
#76: FILE: target-i386/cpu.h:634:
+#define CPUID_7_0_EDX_AVX512_4FMAPS (1U << 3) /* AVX512 Multiply Accumulation
Single Precision */
total: 1 errors, 1 warnings, 53 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
fatal: unrecognized argument: --no-patch
Checking PATCH 27/30: ...
fatal: unrecognized argument: --no-patch
Checking PATCH 28/30: ...
fatal: unrecognized argument: --no-patch
Checking PATCH 29/30: ...
fatal: unrecognized argument: --no-patch
Checking PATCH 30/30: ...
=== OUTPUT END ===
Test command exited with code: 1
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden
- [Qemu-devel] [PULL 21/30] nbd: Improve server handling of shutdown requests, (continued)
- [Qemu-devel] [PULL 21/30] nbd: Improve server handling of shutdown requests, Paolo Bonzini, 2016/11/01
- [Qemu-devel] [PULL 22/30] nbd: Implement NBD_CMD_WRITE_ZEROES on server, Paolo Bonzini, 2016/11/01
- [Qemu-devel] [PULL 23/30] nbd: Implement NBD_CMD_WRITE_ZEROES on client, Paolo Bonzini, 2016/11/01
- [Qemu-devel] [PULL 24/30] qemu-char: do not forward events through the mux until QEMU has started, Paolo Bonzini, 2016/11/01
- [Qemu-devel] [PULL 26/30] x86: add AVX512_4VNNIW and AVX512_4FMAPS features, Paolo Bonzini, 2016/11/01
- [Qemu-devel] [PULL 25/30] slirp: fix CharDriver breakage, Paolo Bonzini, 2016/11/01
- [Qemu-devel] [PULL 28/30] vl: exit qemu on guest panic if -no-shutdown is not set, Paolo Bonzini, 2016/11/01
- [Qemu-devel] [PULL 27/30] checkpatch: allow spaces before parenthesis for 'coroutine_fn', Paolo Bonzini, 2016/11/01
- [Qemu-devel] [PULL 30/30] main-loop: Suppress I/O thread warning under qtest, Paolo Bonzini, 2016/11/01
- [Qemu-devel] [PULL 29/30] docs/rcu.txt: Fix minor typo, Paolo Bonzini, 2016/11/01
- Re: [Qemu-devel] [PULL v2 00/30] Misc patches for 2016-10-31,
no-reply <=
- Re: [Qemu-devel] [PULL v2 00/30] Misc patches for 2016-10-31, Peter Maydell, 2016/11/01