[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [QEMU PATCH v10 2/3] migration: migrate QTAILQ
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [QEMU PATCH v10 2/3] migration: migrate QTAILQ |
Date: |
Wed, 2 Nov 2016 17:38:29 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 |
On 02/11/2016 11:45, Juan Quintela wrote:
>> > + while (qemu_get_byte(f)) {
>> > + elm = g_malloc(size);
> I think this is not generic enough. We really need to allocate a new
> element, and then fill it with default values.
>
> virtio list code use it in this way.
One thing at a time? The allocation and "looping" are different
mechanisms. We can customize the allocation later.
Paolo