[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] hmp: Make block_stream set an explicit job ID
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-devel] [PATCH] hmp: Make block_stream set an explicit job ID |
Date: |
Fri, 4 Nov 2016 15:06:46 +0100 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Am 04.11.2016 um 14:44 hat Alberto Garcia geschrieben:
> A job ID is always required in order to create a block job on a
> non-root node. The default ID (obtained with bdrv_get_device_name())
> is otherwise empty in this scenario and the job cannot be created.
>
> The HMP block_stream command doesn't set a job ID and therefore it
> doesn't allow streaming to intermediate nodes. One solution is to add
> an extra parameter to set a job ID. The other solution is to simply
> use the node name passed to block_stream as job ID. This won't work
> if it's automatically generated (because it contains a '#') but is
> otherwise simple enough for all other cases.
>
> This way 'block_stream node3' will create a job with the ID 'node3'
> and the good old 'block_stream virtio0' will keep the previous
> behaviour and use 'virtio0' for the job ID.
>
> Signed-off-by: Alberto Garcia <address@hidden>
Thanks, applied to the block branch.
Kevin