[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 16/47] virtio-net: mark VIRTIO_NET_F_GSO as legacy
From: |
Michael S. Tsirkin |
Subject: |
[Qemu-devel] [PULL 16/47] virtio-net: mark VIRTIO_NET_F_GSO as legacy |
Date: |
Thu, 10 Nov 2016 18:13:11 +0200 |
virtio 1.0 spec says this is a legacy feature bit,
hide it from guests in modern mode.
Note: for cross-version migration compatibility,
we keep the bit set in host_features.
The result will be that a guest migrating cross-version
will see host features change under it.
As guests only seem to read it once, this should
not be an issue. Meanwhile, will work to fix guests to
ignore this bit in virtio1 mode, too.
Cc: address@hidden
Signed-off-by: Michael S. Tsirkin <address@hidden>
Reviewed-by: Cornelia Huck <address@hidden>
---
hw/net/virtio-net.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c
index 20aa63e..b68c69d 100644
--- a/hw/net/virtio-net.c
+++ b/hw/net/virtio-net.c
@@ -1942,6 +1942,7 @@ static void virtio_net_class_init(ObjectClass *klass,
void *data)
vdc->guest_notifier_pending = virtio_net_guest_notifier_pending;
vdc->load = virtio_net_load_device;
vdc->save = virtio_net_save_device;
+ vdc->legacy_features |= (0x1 << VIRTIO_NET_F_GSO);
}
static const TypeInfo virtio_net_info = {
--
MST
- [Qemu-devel] [PULL 06/47] tests/vhost-user-bridge: use contrib/libvhost-user, (continued)
- [Qemu-devel] [PULL 06/47] tests/vhost-user-bridge: use contrib/libvhost-user, Michael S. Tsirkin, 2016/11/10
- [Qemu-devel] [PULL 07/47] intel_iommu: fixing source id during IOTLB hash key calculation, Michael S. Tsirkin, 2016/11/10
- [Qemu-devel] [PULL 09/47] virtio: make virtqueue_alloc_element static, Michael S. Tsirkin, 2016/11/10
- [Qemu-devel] [PULL 08/47] virtio: rename virtqueue_discard to virtqueue_unpop, Michael S. Tsirkin, 2016/11/10
- [Qemu-devel] [PULL 10/47] pcie_aer: Convert pcie_aer_init to Error, Michael S. Tsirkin, 2016/11/10
- [Qemu-devel] [PULL 12/47] intel_iommu: fix several incorrect endianess and bit fields, Michael S. Tsirkin, 2016/11/10
- [Qemu-devel] [PULL 11/47] virtio-crypto: tag as not hotpluggable and migration, Michael S. Tsirkin, 2016/11/10
- [Qemu-devel] [PULL 13/47] intel_iommu: fix incorrect assert, Michael S. Tsirkin, 2016/11/10
- [Qemu-devel] [PULL 14/47] acpi: fix DMAR device scope for IOAPIC, Michael S. Tsirkin, 2016/11/10
- [Qemu-devel] [PULL 15/47] virtio: allow per-device-class legacy features, Michael S. Tsirkin, 2016/11/10
- [Qemu-devel] [PULL 16/47] virtio-net: mark VIRTIO_NET_F_GSO as legacy,
Michael S. Tsirkin <=
- [Qemu-devel] [PULL 17/47] vhost: Update 'ioeventfd_started' with host notifiers, Michael S. Tsirkin, 2016/11/10
- [Qemu-devel] [PULL 18/47] vhost: Use vbus var instead of VIRTIO_BUS() macro, Michael S. Tsirkin, 2016/11/10
- [Qemu-devel] [PULL 19/47] vhost: migration blocker only if shared log is used, Michael S. Tsirkin, 2016/11/10
- [Qemu-devel] [PULL 20/47] qdev: hotplug: drop HotplugHandler.post_plug callback, Michael S. Tsirkin, 2016/11/10
- [Qemu-devel] [PULL 21/47] nvdimm acpi: drop the lock of fit buffer, Michael S. Tsirkin, 2016/11/10
- [Qemu-devel] [PULL 22/47] pc: memhp: move nvdimm hotplug out of memory hotplug, Michael S. Tsirkin, 2016/11/10
- [Qemu-devel] [PULL 24/47] nvdimm acpi: clean up nvdimm_build_acpi, Michael S. Tsirkin, 2016/11/10
- [Qemu-devel] [PULL 23/47] pc: memhp: stop handling nvdimm hotplug in pc_dimm_unplug, Michael S. Tsirkin, 2016/11/10
- [Qemu-devel] [PULL 25/47] docs: improve the doc of Read FIT method, Michael S. Tsirkin, 2016/11/10
- [Qemu-devel] [PULL 27/47] nvdimm acpi: cleanup nvdimm_build_fit, Michael S. Tsirkin, 2016/11/10