[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/4] qtest: Support named interrupts
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH 2/4] qtest: Support named interrupts |
Date: |
Tue, 22 Nov 2016 18:24:10 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 |
On 22/11/2016 18:22, Cédric Le Goater wrote:
>> +
>> + g_assert(words[1]); /* device */
>> + g_assert(words[2]); /* gpio list */
>> + g_assert(words[3]); /* gpio line in list */
>> + g_assert(words[4]); /* level */
>> + dev = DEVICE(object_resolve_path(words[1], NULL));
>> + if (!dev) {
>> + qtest_send_prefix(chr);
>> + qtest_send(chr, "FAIL Unknown device\n");
>> + return;
>> + }
>> +
>> + irq_num = atoi(words[3]);
>> + level = atoi(words[4]);
>> +
>> + QLIST_FOREACH(ngl, &dev->gpios, node) {
>> + if (strcmp(words[2], ngl->name) == 0 && ngl->num_in > irq_num) {
>> + irq = ngl->in[irq_num];
>> + }
>> + }
>> +
>> + if (irq == NULL) {
>> + qtest_send_prefix(chr);
>> + qtest_send(chr, "FAIL Unknown IRQ\n");
>> + return;
>> + }
>> +
>> + qemu_set_irq(irq, level);
This seems wrong. The IRQ should not be modifiable by the test.
Paolo
>> +
>> + qtest_send_prefix(chr);
>> + qtest_send(chr, "OK\n");
- [Qemu-devel] [PATCH 0/4] Add support for the Epson RX8900 RTC to the aspeed board, Alastair D'Silva, 2016/11/17
- [Qemu-devel] [PATCH 2/4] qtest: Support named interrupts, Alastair D'Silva, 2016/11/17
- Re: [Qemu-devel] [PATCH 2/4] qtest: Support named interrupts, Cédric Le Goater, 2016/11/22
- Re: [Qemu-devel] [PATCH 2/4] qtest: Support named interrupts,
Paolo Bonzini <=
- Re: [Qemu-devel] [PATCH 2/4] qtest: Support named interrupts, Alastair D'Silva, 2016/11/22
- Re: [Qemu-devel] [PATCH 2/4] qtest: Support named interrupts, Paolo Bonzini, 2016/11/22
- Re: [Qemu-devel] [PATCH 2/4] qtest: Support named interrupts, Alastair D'Silva, 2016/11/22
- Re: [Qemu-devel] [PATCH 2/4] qtest: Support named interrupts, Paolo Bonzini, 2016/11/23
- Re: [Qemu-devel] [Qemu-arm] [PATCH 2/4] qtest: Support named interrupts, Edgar E. Iglesias, 2016/11/23
- Re: [Qemu-devel] [Qemu-arm] [PATCH 2/4] qtest: Support named interrupts, Paolo Bonzini, 2016/11/23
[Qemu-devel] [PATCH 4/4] arm: Add an RX8900 RTC to the ASpeed board, Alastair D'Silva, 2016/11/17